From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: NS: ns-expand-space / slider in Preferences dialog not functional Date: Tue, 10 Mar 2009 08:33:18 -0700 (PDT) Message-ID: <200903101533.n2AFXIBL000661@rodan.ics.uci.edu> References: <21F51971-5679-45BF-85A0-D982CA73E722@gmail.com> <5393D476-3312-4DF3-AF39-6D698B7FDA49@gmail.com> <06CD0A2A-6B89-4E1A-BBA6-E91F03A289DD@gmail.com> <200903092315.n29NFcrh021453@rodan.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236699246 19488 80.91.229.12 (10 Mar 2009 15:34:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2009 15:34:06 +0000 (UTC) Cc: Miles Bader , David Reitter , Adrian Robert , YAMAMOTO Mitsuharu , Emacs-Devel devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 10 16:35:23 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lh3z8-0004k2-AH for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2009 16:35:14 +0100 Original-Received: from localhost ([127.0.0.1]:32835 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh3xm-0005hZ-LO for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2009 11:33:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lh3xh-0005hK-Cd for emacs-devel@gnu.org; Tue, 10 Mar 2009 11:33:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lh3xf-0005h8-QV for emacs-devel@gnu.org; Tue, 10 Mar 2009 11:33:45 -0400 Original-Received: from [199.232.76.173] (port=57662 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh3xf-0005h5-Nb for emacs-devel@gnu.org; Tue, 10 Mar 2009 11:33:43 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:35542) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1Lh3xc-0006c5-ME; Tue, 10 Mar 2009 11:33:41 -0400 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2AFXKND028174; Tue, 10 Mar 2009 08:33:21 -0700 (PDT) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2AFXIBL000661; Tue, 10 Mar 2009 08:33:18 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 09 Mar 2009 23:03:38 -0400") Original-Lines: 26 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2AFXKND028174 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109542 Archived-At: Stefan Monnier writes: > > /* FIXME: Because of the typo below, Qbuffered probably never did > > anything useful, so it might as well be removed. */ > > Qbuffered = intern ("bufferd"); > > staticpro (&Qbuffered); > > ??? Whis is this kept around? > > Feel free to remove such dead code. > > > Qfontsize = intern ("fontsize"); > > staticpro (&Qfontsize); > > What about this one? > > What about it? Isn't dealing with font sizes supposed to be cross-platform? font.c: font_open_for_lface [snip] #ifdef HAVE_NS if (size == 0) { Lisp_Object ffsize = get_frame_param(f, Qfontsize); size = NUMBERP (ffsize) ? POINT_TO_PIXEL (XINT (ffsize), f->resy) : 0; } #endif