From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: NS: ns-expand-space / slider in Preferences dialog not functional Date: Mon, 9 Mar 2009 16:15:38 -0700 (PDT) Message-ID: <200903092315.n29NFcrh021453@rodan.ics.uci.edu> References: <21F51971-5679-45BF-85A0-D982CA73E722@gmail.com> <5393D476-3312-4DF3-AF39-6D698B7FDA49@gmail.com> <06CD0A2A-6B89-4E1A-BBA6-E91F03A289DD@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236642780 9170 80.91.229.12 (9 Mar 2009 23:53:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2009 23:53:00 +0000 (UTC) Cc: Miles Bader , David Reitter , Adrian Robert , YAMAMOTO Mitsuharu , Emacs-Devel devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 10 00:54:16 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LgpIV-0005dx-7D for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2009 00:54:15 +0100 Original-Received: from localhost ([127.0.0.1]:34126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgpH9-0006sD-TN for ged-emacs-devel@m.gmane.org; Mon, 09 Mar 2009 19:52:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgohW-0004lX-1w for emacs-devel@gnu.org; Mon, 09 Mar 2009 19:16:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgohU-0004jm-C2 for emacs-devel@gnu.org; Mon, 09 Mar 2009 19:16:01 -0400 Original-Received: from [199.232.76.173] (port=55784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgohU-0004jY-3v for emacs-devel@gnu.org; Mon, 09 Mar 2009 19:16:00 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:49956) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LgohQ-0000Ha-Qt; Mon, 09 Mar 2009 19:15:57 -0400 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n29NFdtq027170; Mon, 9 Mar 2009 16:15:40 -0700 (PDT) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n29NFcrh021453; Mon, 9 Mar 2009 16:15:38 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 09 Mar 2009 09:19:43 -0400") Original-Lines: 66 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n29NFdtq027170 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=1.06, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FM_MULTI_ODD2 1.10, FM_MULTI_ODD3 0.70, FM_MULTI_ODD4 0.70) X-ICS-MailScanner-SpamScore: s X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109532 Archived-At: Stefan Monnier writes: > > But now that the situation is what it is I stand by what I say above: it > > doesn't interfere with anything in core emacs (as it is / should be > > additive with line-spacing), users benefit from it, and others can use it > > to try and see whether it's something that would be worth having on X and > > W32. There's no benefit to removing it. > > This would encourage the use of MacOSX to try the feature. As long as > MacOSX is not Free Software, this goes against our goals. Also I think > it's pretty clear that the `line-spacing' feature can be expanded to > cover the featureset of `ns-expand-space' and that it would be good > since it would remove a redundant setting, and bring that feature to > all architectures. > > So we should remove ns-expand-space right now. If we can come up with > a clean enough patch to extend line-spacing's semantics, we might be > able to consider it for inclusion in Emacs-23.1, otherwise it'll have to > wait for Emacs-23.2. How about similar features that are in the ns specific files, but should be generic (if they should be included at all). When the ns support was included, I sent a few messages with reviews, and found quite a few such things. The ones that I remember right away are in nsfns.m /* FIXME: Because of the typo below, Qbuffered probably never did anything useful, so it might as well be removed. */ Qbuffered = intern ("bufferd"); staticpro (&Qbuffered); ??? Whis is this kept around? Qfontsize = intern ("fontsize"); staticpro (&Qfontsize); What about this one? DEFVAR_LISP ("ns-icon-type-alist", &Vns_icon_type_alist, doc: /* Alist of elements (REGEXP . IMAGE) for images of icons associated to frames. If the title of a frame matches REGEXP, then IMAGE.tiff is selected as the image of the icon representing the frame when it's miniaturized. If an element is t, then Emacs tries to select an icon based on the filetype of the visited file. The images have to be installed in a folder called English.lproj in the Emacs folder. You have to restart Emacs after installing new icons. Example: Install an icon Gnus.tiff and execute the following code (setq ns-icon-type-alist (append ns-icon-type-alist '((\"^\\\\*\\\\(Group\\\\*$\\\\|Summary \\\\|Article\\\\*$\\\\)\" . \"Gnus\")))) When you miniaturize a Group, Summary or Article frame, Gnus.tiff will be used as the image of the icon representing the frame. */); Vns_icon_type_alist = Fcons (Qt, Qnil); This definitely looks like it should be generic, or not included at all. There are a few more in ns-win.el. Like redefining the standard menu structure, but there are more.