bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

[Markus Triska]

With p.ps from:

   http://www.logic.at/prolog/p.ps

when I do:

   $ emacs -Q p.ps

and press:

   C-c C-c - - - - - - -

the image shrinks, as expected. Then, when I quit Emacs and again do:

   $ emacs -Q p.ps

followed by C-c C-c, doc-view unexpectedly shows the small version
from the previous run. When I then press "-", it "shrinks" the image
so that the result is in fact larger than the just displayed image.


In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2009-01-06 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

[Tassilo Horn]

Markus Triska <markus.triska@gmx.at> writes:

Hi Markus,

> With p.ps from:
>
>    http://www.logic.at/prolog/p.ps
>
> when I do:
>
>    $ emacs -Q p.ps
>
> and press:
>
>    C-c C-c - - - - - - -
>
> the image shrinks, as expected. Then, when I quit Emacs and again do:
>
>    $ emacs -Q p.ps
>
> followed by C-c C-c, doc-view unexpectedly shows the small version
> from the previous run.

That's no bug.  When you fire up emacs again doc-view uses the cached
files, which are the small ones now.

> When I then press "-", it "shrinks" the image so that the result is in
> fact larger than the just displayed image.

Yeah, cause the resulution factor is at the default value again and
doc-view reconverts the doc using this default value x 0.95 or so.

I'm closing that "bug".

Bye,
Tassilo

bug#2548: marked as done (23.0.60; doc-view: unexpected reuse of previously scaled image)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]


Your message dated Tue, 03 Mar 2009 12:54:34 +0100
with message-id <87fxhult39.fsf@thinkpad.tsdh.de>
and subject line Re: bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image
has caused the Emacs bug report #2548,
regarding 23.0.60; doc-view: unexpected reuse of previously scaled image
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2548: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2548
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3045 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; doc-view: unexpected reuse of previously scaled image
Date: Tue,  3 Mar 2009 02:31:41 +0100 (CET)
Message-ID: <20090303013141.A97F6C65FAA@mt-computer.local>

With p.ps from:

   http://www.logic.at/prolog/p.ps

when I do:

   $ emacs -Q p.ps

and press:

   C-c C-c - - - - - - -

the image shrinks, as expected. Then, when I quit Emacs and again do:

   $ emacs -Q p.ps

followed by C-c C-c, doc-view unexpectedly shows the small version
from the previous run. When I then press "-", it "shrinks" the image
so that the result is in fact larger than the just displayed image.


In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2009-01-06 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t




[-- Attachment #3: Type: message/rfc822, Size: 2725 bytes --]

From: Tassilo Horn <tassilo@member.fsf.org>
To: Markus Triska <markus.triska@gmx.at>
Cc: 2548-done@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org
Subject: Re: bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image
Date: Tue, 03 Mar 2009 12:54:34 +0100
Message-ID: <87fxhult39.fsf@thinkpad.tsdh.de>

Markus Triska <markus.triska@gmx.at> writes:

Hi Markus,

> With p.ps from:
>
>    http://www.logic.at/prolog/p.ps
>
> when I do:
>
>    $ emacs -Q p.ps
>
> and press:
>
>    C-c C-c - - - - - - -
>
> the image shrinks, as expected. Then, when I quit Emacs and again do:
>
>    $ emacs -Q p.ps
>
> followed by C-c C-c, doc-view unexpectedly shows the small version
> from the previous run.

That's no bug.  When you fire up emacs again doc-view uses the cached
files, which are the small ones now.

> When I then press "-", it "shrinks" the image so that the result is in
> fact larger than the just displayed image.

Yeah, cause the resulution factor is at the default value again and
doc-view reconverts the doc using this default value x 0.95 or so.

I'm closing that "bug".

Bye,
Tassilo

bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

[Markus Triska]

Tassilo Horn <tassilo@member.fsf.org> writes:

> the resulution factor is at the default value again and doc-view
> reconverts the doc using this default value x 0.95 or so.

If caching of the scaled picture is desired, the resolution factor
should be cached along with the image in my opinion, so that shrinking
and enlarging work consistently across different runs of Emacs.

bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

[Tassilo Horn]

Markus Triska <markus.triska@gmx.at> writes:

>> the resulution factor is at the default value again and doc-view
>> reconverts the doc using this default value x 0.95 or so.
>
> If caching of the scaled picture is desired, the resolution factor
> should be cached along with the image in my opinion, so that shrinking
> and enlarging work consistently across different runs of Emacs.

I agree.  I hope I can implement that at the weekend.

Bye,
Tassilo

bug#2548: 23.0.60; doc-view: unexpected reuse of previously scaled image

[Tassilo Horn]

Tassilo Horn <tassilo@member.fsf.org> writes:

Hi Markus,

>>> the resulution factor is at the default value again and doc-view
>>> reconverts the doc using this default value x 0.95 or so.
>>
>> If caching of the scaled picture is desired, the resolution factor
>> should be cached along with the image in my opinion, so that
>> shrinking and enlarging work consistently across different runs of
>> Emacs.
>
> I agree.  I hope I can implement that at the weekend.

It's in CVS now.  I tested it briefly and it works fine for me.  Please
give it a try.

Bye,
Tassilo