From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aaron Ecay Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2352: 23.0.90; Vertical window border on OS X Date: Mon, 16 Feb 2009 22:51:56 -0500 Message-ID: <20090217035156.GI48993@awe.local> Reply-To: Aaron Ecay , 2352@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1234854761 2668 80.91.229.12 (17 Feb 2009 07:12:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Feb 2009 07:12:41 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 17 08:13:57 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LZK9O-0002YO-N6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Feb 2009 08:13:51 +0100 Original-Received: from localhost ([127.0.0.1]:56544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZK84-00063y-GF for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Feb 2009 02:12:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZHBN-00033X-Up for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2009 23:03:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZHBN-00033K-BE for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2009 23:03:41 -0500 Original-Received: from [199.232.76.173] (port=37661 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZHBN-00033H-8X for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2009 23:03:41 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42890) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LZHBM-0001UH-CM for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2009 23:03:40 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1H43Zan027263; Mon, 16 Feb 2009 20:03:35 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1H403rR026125; Mon, 16 Feb 2009 20:00:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Aaron Ecay Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 17 Feb 2009 04:00:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2352 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123484272724850 (code B ref -1); Tue, 17 Feb 2009 04:00:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 17 Feb 2009 03:52:07 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1H3q39A024844 for ; Mon, 16 Feb 2009 19:52:05 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:47322) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LZGy6-0004Iu-H6 for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:49:58 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LZH05-0000jU-SP for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:03 -0500 Original-Received: from qw-out-1920.google.com ([74.125.92.149]:11541) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZH05-0000jM-Fr for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:01 -0500 Original-Received: by qw-out-1920.google.com with SMTP id 4so631530qwk.24 for ; Mon, 16 Feb 2009 19:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=u20arzYQDeLr8Kn6xg80LTETzYJ1Gz/u2+BlO2SkK7E=; b=wrPs8C7vZlOr4i5s36+Z+qBsCimohYVJnn76NenilEqynIDMS6o3dByXQ+TcirOkNl YwAiCSxVacm9Dm4cirVbtUjYS843uwa7Pp8moNHpzUo0+ReQ/bgMkTUYkQ/GNxSQNQ0I L6dQ6DWq/GeNUMregemKOydLd6c/KW7Fqxck4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=Q4F5tuaYpzkYM4w/jJOtbzegwiA4MrMk/cPixv7yvmxvNkoipD939yybz2dUnouaMS ShhX2QAgr8EO+EAFYWEjxEusV4A9IStXoij9hh1zS0e/yjGzpAQc4ZahqvvuWqeMHFsK 6wK1/AuFMK8zm/mMx/jt6zeymoZGNa4D2AiJY= Original-Received: by 10.224.28.144 with SMTP id m16mr2292408qac.86.1234842720211; Mon, 16 Feb 2009 19:52:00 -0800 (PST) Original-Received: from localhost (dhcp0403.vpm.resnet.group.upenn.edu [165.123.165.237]) by mx.google.com with ESMTPS id 7sm11828839ywo.57.2009.02.16.19.51.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Feb 2009 19:51:59 -0800 (PST) Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 16 Feb 2009 23:03:41 -0500 X-Mailman-Approved-At: Tue, 17 Feb 2009 02:11:54 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25353 gmane.emacs.pretest.bugs:23923 Archived-At: Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: On the OS X (and presumably GNUstep) port, the drawing of a vertical border between two frames does not work. This currently uses the NSDrawGroove function from the Cocoa/GNUstep API. According to http://preview.tinyurl.com/c2flh9 (apologies for the shortening, the link goes to some Apple API documentation and the URL is gargantuan), the function NSDrawGroove "Draws a gray-filled rectangle with a groove border". This would not be desirable behavior in any case, as making the divider gray disregards the setting of the vertical-border face. And in any event, it appears to be a no-op on OS X.5 (Leopard) -- after doing a C-x 3, there is no vertical frame border apparent against either a dark or a white background. The function to use, IMHO, is NSRectFill; substituting this fn makes the border drawing happen. NSRectFill was used in Emacs 22 (`emacs22' branch in the git repo, src/nsterm.m line 2466). The patch below fixes this behavior. It also restores another bit of v.22 status quo, namely making the vertical window divider one pixel in width, instead of the current two. ####### BEGIN PATCH ####### diff --git a/src/nsterm.m b/src/nsterm.m index b674eda..c2ebf9f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2454,7 +2454,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) { struct frame *f = XFRAME (WINDOW_FRAME (w)); struct face *face; - NSRect r = NSMakeRect (x, y0, 2, y1-y0); + NSRect r = NSMakeRect (x, y0, 1, y1-y0); NSTRACE (ns_draw_vertical_window_border); @@ -2463,7 +2463,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) [ns_lookup_indexed_color(face->foreground, f) set]; ns_focus (f, &r, 1); - NSDrawGroove (r, r); + NSRectFill(r); ns_unfocus (f); } ####### END PATCH ####### If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /opt/src/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG for instructions. In GNU Emacs 23.0.90.7 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-02-15 on dhcp0403.vpm.resnet.group.upenn.edu Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t paredit-mode: t auto-insert-mode: t desktop-save-mode: t mac-print-mode: t shell-dirtrack-mode: t show-paren-mode: t global-auto-complete-mode: t auto-complete-mode: t display-battery-mode: t icomplete-mode: t savehist-mode: t recentf-mode: t partial-completion-mode: t display-time-mode: t ns-extended-platform-support-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-r C-h C-g C-e # SPC T O D O : SPC f u n c t i o n SPC t o SPC e d i t SPC i n SPC t e r m i n a l SPC ( e ) C-x C-s C-h f r e p o r t - e m C-h v u s e r - m a s h i s h u u q h n n n n n n n s C-e C-e M-; T O O D : SPC D O : SPC m o v C-M-x C-x 3 C-x 0 C-x < M-x r e p o r t Recent messages: Mark saved where search started byte-code: End of buffer [3 times] byte-code: Beginning of buffer [3 times] Saving file /Users/aecay/home/.zshrc... Wrote /Users/aecay/home/.zshrc Type "q" to quit. [2 times] Entering debugger... Back to top level. Mark set