all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Miles Bader" <miles@gnu.org>, Röhler <andreas.roehler@online.de>,
	emacs-devel@gnu.org
Subject: Re: end-of-defun is fubsr.
Date: Fri, 13 Feb 2009 18:57:56 +0000	[thread overview]
Message-ID: <20090213185756.GD2975@muc.de> (raw)
In-Reply-To: <jwv8woa467w.fsf-monnier+emacs@gnu.org>

Hi, Stefan,

On Fri, Feb 13, 2009 at 12:06:26PM -0500, Stefan Monnier wrote:
> >> Did you notice any other problem?
> > Well, the ones I pointed out before:

> Great, thanks,

Sorry, here's something a bit more constructive:

#########################################################################
*** lisp.el~	2009-02-12 12:10:53.000000000 +0000
--- lisp.el	2009-02-13 18:49:26.780916880 +0000
***************
*** 314,322 ****
  
  (defvar end-of-defun-function #'forward-sexp
    "Function for `end-of-defun' to call.
! This is used to find the end of the defun.
! It is called with no argument, right after calling `beginning-of-defun-raw'.
! So the function can assume that point is at the beginning of the defun body.")
  
  (defun buffer-end (arg)
    "Return the \"far end\" position of the buffer, in direction ARG.
--- 314,326 ----
  
  (defvar end-of-defun-function #'forward-sexp
    "Function for `end-of-defun' to call.
! This should move point to the next end of defun and return t on success,
! nil on failure.  It should not move further forward into any whitespace or
! onto the next line.
! 
! It is called with no argument.
! The function can assume that point is at the beginning of a defun
! body or before the first defun in the buffer.")
  
  (defun buffer-end (arg)
    "Return the \"far end\" position of the buffer, in direction ARG.
#########################################################################

Another thing: in an elisp buffer, if (point-min) is in the middle of a
defun, C-M-e takes point to the next but one EOD.  CC Mode is just as
bad.  ;-)

Should end-of-defun perhaps widen the buffer around its machinations?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).




  reply	other threads:[~2009-02-13 18:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02  8:13 end-of-defun acts weirdly in c-mode; also, mark-defun in c-mode Miles Bader
2009-02-02 20:27 ` Alan Mackenzie
2009-02-02 22:46   ` Stefan Monnier
2009-02-03  9:17   ` Miles Bader
2009-02-03 10:50     ` Alan Mackenzie
2009-02-03 11:23       ` Miles Bader
2009-02-03 11:35         ` Miles Bader
2009-02-03 12:29         ` Alan Mackenzie
2009-02-03 13:00           ` Alan Mackenzie
2009-02-03 16:09             ` end-of-defun is fubsr. [Was: end-of-defun acts weirdly in c-mode] Alan Mackenzie
2009-02-03 15:56               ` Juanma Barranquero
2009-02-03 16:34                 ` end-of-defun is fubsr Chong Yidong
2009-02-03 17:18                   ` Andreas Roehler
2009-02-04 11:33                     ` Alan Mackenzie
2009-02-04 14:54                       ` Andreas Roehler
2009-02-03 16:40                 ` end-of-defun is fubsr. [Was: end-of-defun acts weirdly in c-mode] Alan Mackenzie
2009-02-03 17:13               ` end-of-defun is fubsr Stefan Monnier
2009-02-03 18:58                 ` Alan Mackenzie
2009-02-03 20:50                   ` Stefan Monnier
2009-02-04  0:14                     ` Alan Mackenzie
2009-02-04  2:21                       ` Stefan Monnier
2009-02-04 13:37                         ` Alan Mackenzie
2009-02-04 14:29                           ` Stefan Monnier
2009-02-04 15:44                             ` Alan Mackenzie
2009-02-05 10:37                               ` Andreas Roehler
2009-02-12 21:35                               ` Stefan Monnier
2009-02-13 11:08                                 ` Alan Mackenzie
2009-02-13 14:31                                   ` Stefan Monnier
2009-02-13 16:42                                     ` Alan Mackenzie
2009-02-13 17:06                                       ` Stefan Monnier
2009-02-13 18:57                                         ` Alan Mackenzie [this message]
2009-02-14  4:22                                           ` Stefan Monnier
2009-02-14 18:00                                             ` Alan Mackenzie
2009-02-14 21:16                                               ` Stefan Monnier
2009-02-14 23:25                                                 ` Alan Mackenzie
2009-02-15  0:57                                                   ` Miles Bader
2009-02-15 19:26                                                   ` Stefan Monnier
2009-02-15 22:00                                                     ` Alan Mackenzie
2009-02-05 11:44                             ` Problems C Mode has with src/regex.c [was: end-of-defun is fubsr.] Alan Mackenzie
2009-02-05 21:50               ` end-of-defun acts weirdly in c-mode Alan Mackenzie
2009-02-06  1:03                 ` Glenn Morris
2009-02-06 12:23                   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213185756.GD2975@muc.de \
    --to=acm@muc.de \
    --cc=andreas.roehler@online.de \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.