bug#2313: 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite

[Xavier Maillard <xma@gnu.org>]

when calling sql-sqlite, it asks for a user, a password, a host
to connect to a database. Problem is sqlite3 (dunno for other
sqlite versions) will refuse to do anything with these parameters
and just dies.

Here is the output of sqlite3 -help on my machine (slackware
GNU/linux):

Usage: sqlite3 [OPTIONS] FILENAME [SQL]
FILENAME is the name of an SQLite database. A new database is created
if the file does not previously exist.
OPTIONS include:
   -init filename       read/process named file
   -echo                print commands before execution
   -[no]header          turn headers on or off
   -bail                stop after hitting an error
   -interactive         force interactive I/O
   -batch               force batch I/O
   -column              set output mode to 'column'
   -csv                 set output mode to 'csv'
   -html                set output mode to HTML
   -line                set output mode to 'line'
   -list                set output mode to 'list'
   -separator 'x'       set output field separator (|)
   -nullvalue 'text'    set text string for NULL values
   -version             show SQLite version

I guess this patch would be enough:

*** /tmp/sql.el.orig	2009-02-12 23:22:31.000000000 +0100
--- /tmp/sql.el	2009-02-12 23:23:30.000000000 +0100
***************
*** 356,362 ****
       :sqli-prompt-length 0)
      (sqlite
       :font-lock sql-mode-sqlite-font-lock-keywords
!      :sqli-login (user password server database)
       :sqli-connect sql-connect-sqlite
       :sqli-prompt-regexp "^sqlite> "
       :sqli-prompt-length 8)
--- 356,362 ----
       :sqli-prompt-length 0)
      (sqlite
       :font-lock sql-mode-sqlite-font-lock-keywords
!      :sqli-login (database)
       :sqli-connect sql-connect-sqlite
       :sqli-prompt-regexp "^sqlite> "
       :sqli-prompt-length 8)
***************
*** 2611,2622 ****
    (let ((params))
      (if (not (string= "" sql-database))
  	(setq params (append (list sql-database) params)))
-     (if (not (string= "" sql-server))
- 	(setq params (append (list (concat "--host=" sql-server)) params)))
-     (if (not (string= "" sql-password))
- 	(setq params (append (list (concat "--password=" sql-password)) params)))
-     (if (not (string= "" sql-user))
- 	(setq params (append (list (concat "--user=" sql-user)) params)))
      (if (not (null sql-sqlite-options))
  	(setq params (append sql-sqlite-options params)))
      (set-buffer (apply 'make-comint "SQL" sql-sqlite-program
--- 2611,2616 ----

and the mandatory ChangeLog entry:

2009-02-12  Xavier Maillard  <xma@gnu.org>

	* sql.el (sql-connect-sqlite, sql-product-alist): user, password
	and server are irrelevant for sqlite, remove them.


Hope that'll help


In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12)
 of 2009-02-10 on zogzog
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--without-xft''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_US.UTF-8
  value of $LC_CTYPE: fr_FR.UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LC_MONETARY: fr_FR.UTF-8
  value of $LC_NUMERIC: en_US.UTF-8
  value of $LC_TIME: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  t: t
  rcirc-track-minor-mode: t
  eev-mode: t
  shell-dirtrack-mode: t
  jabber-activity-mode: t
  auto-insert-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  show-paren-mode: t
  global-auto-revert-mode: t
  display-time-mode: t
  recentf-mode: t
  icomplete-mode: t
  desktop-save-mode: t
  auto-image-file-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <up> <return> <return> P . S . <left> <left> 
<left> <left> P . C-e <backspace> : SPC f e e l SPC 
f r e e SPC t o SPC d i s t r i b u t e SPC t h i s 
SPC m e s s a g e SPC t o SPC t h e SPC * r i g h t 
* SPC e e v SPC l i s t SPC i f SPC a p p l i c a b 
l e . <down> <down> <down> <down> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<up> <return> R e g a r d s , <return> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <down> 
<down> C-SPC <right> C-w <backspace> SPC <backspace> 
<backspace> SPC <left> <left> <left> <left> C-e " <backspace> 
C-a <right> <right> <right> <right> <right> <backspace> 
C-c C-c M-x m y - s e n d <tab> <return> M-x e m a 
c s - b u <backspace> <backspace> r e <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> b u g <backspace> <backspace> <backspace> 
r e p o <tab> r <tab> <return>

Recent messages:
Wrote /home/xma/var/queue/out-1
Sending...done
Sending out-1...
Sending...
Added to /home/xma/mail/OUT-SENT
Sending...done
Sending out-1...done
All sent or no message to send.
Making completion list...
Killing buffer *Completions*


	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org