From: Nick Roberts <nickrob@snap.net.nz>
To: emacs-pretest-bug@gnu.org
Subject: bug#2092: 23.0.60; vc-svn-diff
Date: Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) [thread overview]
Message-ID: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> (raw)
vc-svn-diff fails when oldvers equals (vc-working-revision f).
In that case "svn diff" executes with no -r argument and only gives
a diff if the file is locally modified.
To see this bug, do vc-print-log on a file under Subversion control that
needs an update (newer revisions have been committed by someone else).
Place the cursor over the revision after (in time) the working-revision (the
revison with the number in the modeline) and press d (log-viw-diff).
I think this clause needs to be removed:
(and oldvers
files
(catch 'no
(dolist (f files)
(or (equal oldvers (vc-working-revision f))
(throw 'no nil)))
t)
;; Use nil rather than the current revision because svn handles
;; it better (i.e. locally). Note that if _any_ of the files
;; has a different revision, we fetch the lot, which is
;; obviously sub-optimal.
(setq oldvers nil))
I don't see how it could ever work (please note that I'm not saying that
it could never work just that I don't see how it could).
--
Nick http://www.inet.net.nz/~nickrob
next reply other threads:[~2009-01-28 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 6:34 Nick Roberts [this message]
2009-02-01 22:39 ` bug#2092: 23.0.60; vc-svn-diff Stefan Monnier
2009-02-04 11:03 ` Nick Roberts
2009-02-04 19:42 ` Stefan Monnier
2009-02-04 11:10 ` bug#2092: marked as done (23.0.60; vc-svn-diff) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128063434.74C018FC6D@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=2092@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.