bug#1821: 23.0.60; customizing ediff-highlight-all-diffs or ediff-use-faces customizations => no effect

bug#1821: 23.0.60; customizing ediff-highlight-all-diffs or ediff-use-faces customizations => no effect

[David Abrahams]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

  emacs -q -load einit.el

where einit.el is enclosed.  I have also enclosed a patch that fixes
this problem, which I hereby place into the public domain.


[-- Attachment #2: einit.el --]
[-- Type: application/emacs-lisp, Size: 334 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: ediff-init.el.patch --]
[-- Type: text/x-diff, Size: 1148 bytes --]

--- ediff-init.el.~1.95.~	2008-12-03 00:48:23.000000000 -0500
+++ ediff-init.el	2009-01-07 16:43:55.469063558 -0500
@@ -560,7 +560,6 @@
   :group 'ediff)
 
 
-(ediff-defvar-local ediff-use-faces t "")
 (defcustom ediff-use-faces t
   "If t, differences are highlighted using faces, if device supports faces.
 If nil, differences are highlighted using ASCII flags, ediff-before-flag
@@ -568,6 +567,7 @@
 highlighted using ASCII flags."
   :type 'boolean
   :group 'ediff-highlighting)
+(ediff-defvar-local ediff-use-faces t "")
 
 ;; this indicates that diff regions are word-size, so fine diffs are
 ;; permanently nixed; used in ediff-windows-wordwise and ediff-regions-wordwise
@@ -604,13 +604,13 @@
   :type 'boolean
   :group 'ediff)
 
-(ediff-defvar-local ediff-highlight-all-diffs t "")
 (defcustom ediff-highlight-all-diffs t
   "If nil, only the selected differences are highlighted.
 Otherwise, all difference regions are highlighted, but the selected region is
 shown in brighter colors."
   :type 'boolean
   :group 'ediff-highlighting)
+(ediff-defvar-local ediff-highlight-all-diffs t "")
 
 
 ;; The suffix of the control buffer name.

[-- Attachment #4: Type: text/plain, Size: 3033 bytes --]



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.2 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-01-05 on mcbain
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
configured using `configure  '--with-x-toolkit=gtk' '--prefix=/usr/local''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  show-paren-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x b e d i f <tab> e <backspace> i n <tab> <return> 
C-x v = C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n 
C-n C-x C-n M-x d i f f - <tab> C-g M-x c u s t o m 
<tab> - a p <tab> <return> v c - d i <tab> <backspace> 
<backspace> C-g M-x c u c s t o <backspace> <backspace> 
<backspace> s <backspace> <backspace> s t o m i <tab> 
- v a r <tab> <return> v c - = <backspace> d i f <tab> 
<tab> s w <tab> <return> C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-p C-p C-p C-e C-n C-e C-, C-, 
C-n C-n C-n C-n C-p C-p C-p C-p C-n C-n C-n C-n C-n 
C-n C-e C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n 
C-n C-n C-n C-n C-n C-p C-p C-p C-p C-, C-, <return> 
3 C-n - d C-p C-f C-f <return> 2 <tab> - d u C-n C-a 
C-. C-b <return> 1 C-x C-b C-x v = C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-x C-w / t m p / e d i f f 
- i n i t . e l . p a t c h <return> M-x e m a c s 
- b u f <backspace> g <return> <M-backspace> r e <M-backspace> 
<M-backspace> r e p o <tab> r t - e m <tab> <retur
n>

Recent messages:
To install your edits, invoke [State] and choose the Set operation [2 times]
M-TAB: complete field; RET: enter value
Wrote /home/dave/elisp/custom.el
Compiling /home/dave/elisp/custom.el...done
Wrote /home/dave/elisp/custom.elc
Finding changes in /home/dave/src/emacs/lisp/ediff-init.el...done
Wrote /tmp/ediff-init.el.patch
Making completion list...
Scanning for dabbrevs...100% [2 times]
Mark deactivated

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

bug#1821: 23.0.60; customizing ediff-highlight-all-diffs or ediff-use-faces customizations => no effect

[Chong Yidong]

Hi Michael,

Could you take a look at the bug report at

http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1821

Thanks

bug#1821: 23.0.60; customizing ediff-highlight-all-diffs or ediff-use-faces customizations => no effect

[Michael Kifer]

On Sun, 25 Jan 2009 12:09:36 -0500
Chong Yidong <cyd@stupidchicken.com> wrote:

> Hi Michael,
> 
> Could you take a look at the bug report at
> 
> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1821
> 
> Thanks


Thank you, the patch is correct. I'll fix that in cvs.

bug#1821: 23.0.60; customizing ediff-highlight-all-diffs or ediff-use-faces customizations => no effect

[Glenn Morris]

Version: 24.1

As far as I can see, this patch was never applied. So I applied it.