From: Dan Nicolaescu <dann@ics.uci.edu>
To: Ali Bahrami <ali_gnu@emvision.com>
Cc: 1191@emacsbugs.donarmstrong.com
Subject: bug#1191: How to contribute back changes for Emacs on Solaris
Date: Thu, 11 Dec 2008 10:14:51 -0800 (PST) [thread overview]
Message-ID: <200812111814.mBBIEpki000573@mothra.ics.uci.edu> (raw)
In-Reply-To: <4941579A.9050603@emvision.com> (Ali Bahrami's message of "Thu, 11 Dec 2008 11:10:34 -0700")
Ali Bahrami <ali_gnu@emvision.com> writes:
> Dan Nicolaescu wrote:
> > Ali Bahrami <ali_gnu@emvision.com> writes:
> >
> > > This message is a follow up to one I sent to emacs-devel
> > > last July:
> > > >
> > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html
> > > > The question had to do with why emacs wasn't using dldump()
> > > to produce the dumped executable under Solaris. It had been using it
> > > up until 2002, at which point it was commented out, and it wasn't
> > > clear why. No one knew the reason, and the consensus was "try it and see".
> > > > Since then, I've done some work to integrate emacs with
> > > OpenSolaris as a standard package. I turned on dldump(),
> > > and have been using the emacs binaries built with it daily
> > > since July without issue.
> > > > So now, I have some things I'd like to send back up stream
> > > and get integrated into the emacs distribution:
> > > > - Man pages for things installed to /usr/bin that
> > didn't
> > > already have a manpage:
> > > b2m.1
> > > ebrowse.1
> > > grep-changelog.1
> > > rcs-checkin.1
> > > - Small changes to config.guess and configure to properly
> > > detect amd64 hardware running Solaris.
> > > - Use dldump() instead of the generic ELF dump code
> > > under Solaris.
> > > - Use the system malloc under Solaris (at least with
> > > amd64, emacs crashes without this).
> > > > The manpages can be viewed at:
> > > >
> > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1
> > > > and the patches at:
> > > >
> > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch
> > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch
> > > > The patches are for emacs 22.1. I've examined 22.3, and the
> > > changes are applicable there as well. If 22.1 diffs are OK,
> > > that's easiest for me, but if not, then please let me know what
> > > I need to supply. These diffs are all very short, affecting a
> > > small number of lines in each file.
> > > > So my questions: How can I go about submitting these
> > changes?
> > > Is there someone who might work with me to get this done?
> > > What format would you need to get them in, and where can
> > > I send them?
> >
> > Your patches for the Solaris configuration are now in.
> > config.guess has been updated from upstream with your changes.
> > There's a man page for ebrowse now.
> > Not sure what to do about the man pages for b2m, grep-changelog, and
> > rcs-checkin. You might want to open a separate bug for them.
> >
> > Thanks
> >
> > --dan
>
>
> I'm not sure what I'll do about the manpages, but I don't consider them part of
> this bug anymore.
>
> So, we appear to be done, except for the issue I flagged a couple
> of days ago. Ben made a modification to my patch for config.guess
> (dropping the use of a fully qualified path for 'echo') that causes
> emacs to not build correctly for a Solaris user using the bash shell.
> It does build successfully, but will always choose to build a 64-bit binary.
>
> I sent mail to Ben about it, and we'll see what he says. However, you
> should probably hold off on closing things out just yet.
Ben made the changes you requested:
commit 7086ee26381fdcc645d12c3177ee0be072dd82ef
Author: Ben Elliston <bje@gnu.org>
Date: Thu Dec 11 15:31:45 2008 +1100
* config.guess (i86pc:SunOS:5.*:*, i86xen:SunOS:5.*:*): The full
path to /usr/bin/echo is necessary to work around the shell
builtins for echo that do not handle newlines. From Ali
Bahrami.
and those are checked in the emacs CVS now. Is that what you had in
mind? If yes, please verify that things work for you now.
--dan
next prev parent reply other threads:[~2008-12-11 18:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812120309.mBC392kD002742@mothra.ics.uci.edu>
2008-10-17 3:44 ` bug#1191: How to contribute back changes for Emacs on Solaris Ali Bahrami
2008-10-17 6:22 ` Dan Nicolaescu
2008-10-17 16:27 ` Ali Bahrami
2008-10-17 23:52 ` Dan Nicolaescu
2008-10-19 3:18 ` Ali Bahrami
2008-10-20 22:29 ` Dan Nicolaescu
2008-10-23 6:45 ` Ali Bahrami
2008-10-23 16:23 ` Ali Bahrami
2008-10-23 19:35 ` Dan Nicolaescu
2008-10-23 22:51 ` Ali Bahrami
2008-10-23 23:06 ` Dan Nicolaescu
2008-10-23 23:21 ` Ali Bahrami
2008-10-24 0:22 ` Dan Nicolaescu
2008-12-11 17:47 ` Dan Nicolaescu
2008-12-11 18:10 ` Ali Bahrami
2008-12-11 18:14 ` Dan Nicolaescu [this message]
2008-12-11 18:21 ` Ali Bahrami
2008-12-12 2:55 ` Ali Bahrami
2008-12-12 3:15 ` bug#1191: marked as done (How to contribute back changes for Emacs on Solaris) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812111814.mBBIEpki000573@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=1191@emacsbugs.donarmstrong.com \
--cc=ali_gnu@emvision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.