From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1191: How to contribute back changes for Emacs on Solaris Date: Thu, 11 Dec 2008 09:47:05 -0800 (PST) Message-ID: <200812111747.mBBHl5Vb000507@mothra.ics.uci.edu> References: <48F80A14.7010502@emvision.com> Reply-To: Dan Nicolaescu , 1191@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229018717 21339 80.91.229.12 (11 Dec 2008 18:05:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Dec 2008 18:05:17 +0000 (UTC) Cc: 1191@emacsbugs.donarmstrong.com To: Ali Bahrami Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 11 19:06:20 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LApvC-0003gr-Ht for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 19:05:58 +0100 Original-Received: from localhost ([127.0.0.1]:55792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LApu1-000068-CZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 13:04:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAptg-00086d-GX for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:04:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LApte-00080b-3J for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:04:22 -0500 Original-Received: from [199.232.76.173] (port=45312 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAptd-000802-2g for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:04:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43934) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAptc-0001dU-8z for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:04:20 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBI4Ifw019578; Thu, 11 Dec 2008 10:04:18 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBBHo3VZ014543; Thu, 11 Dec 2008 09:50:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 11 Dec 2008 17:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1191 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1191-submit@emacsbugs.donarmstrong.com id=B1191.122901764014266 (code B ref 1191); Thu, 11 Dec 2008 17:50:03 +0000 X-Spam-Bayes: score:0.0000 Tokens: new, 100; hammy, 108; neutral, 100; spammy, 5. spammytokens:0.987-1--hardware, 0.987-1--affecting, 0.987-1--integrated, 0.987-1--dumped, 0.891-+--knew hammytokens:0.000-+--emacs, 0.000-+--Emacs, 0.000-+--H*i:message, 0.000-+--H*i:2008, 0.000-+--HX-Debbugs-No-Ack:yes Original-Received: (at 1191) by emacsbugs.donarmstrong.com; 11 Dec 2008 17:47:20 +0000 Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBHlH1D014259 for <1191@emacsbugs.donarmstrong.com>; Thu, 11 Dec 2008 09:47:18 -0800 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mBBHl6ce024669; Thu, 11 Dec 2008 09:47:06 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBBHl5Vb000507; Thu, 11 Dec 2008 09:47:05 -0800 (PST) In-Reply-To: <48F80A14.7010502@emvision.com> (Ali Bahrami's message of "Thu, 16 Oct 2008 21:44:20 -0600") Original-Lines: 67 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mBBHl6ce024669 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 11 Dec 2008 13:04:22 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23188 Archived-At: Ali Bahrami writes: > This message is a follow up to one I sent to emacs-devel > last July: > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html > > The question had to do with why emacs wasn't using dldump() > to produce the dumped executable under Solaris. It had been using it > up until 2002, at which point it was commented out, and it wasn't > clear why. No one knew the reason, and the consensus was "try it and see". > > Since then, I've done some work to integrate emacs with > OpenSolaris as a standard package. I turned on dldump(), > and have been using the emacs binaries built with it daily > since July without issue. > > So now, I have some things I'd like to send back up stream > and get integrated into the emacs distribution: > > - Man pages for things installed to /usr/bin that didn't > already have a manpage: > b2m.1 > ebrowse.1 > grep-changelog.1 > rcs-checkin.1 > - Small changes to config.guess and configure to properly > detect amd64 hardware running Solaris. > - Use dldump() instead of the generic ELF dump code > under Solaris. > - Use the system malloc under Solaris (at least with > amd64, emacs crashes without this). > > The manpages can be viewed at: > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1 > > and the patches at: > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch > > The patches are for emacs 22.1. I've examined 22.3, and the > changes are applicable there as well. If 22.1 diffs are OK, > that's easiest for me, but if not, then please let me know what > I need to supply. These diffs are all very short, affecting a > small number of lines in each file. > > So my questions: How can I go about submitting these changes? > Is there someone who might work with me to get this done? > What format would you need to get them in, and where can > I send them? Your patches for the Solaris configuration are now in. config.guess has been updated from upstream with your changes. There's a man page for ebrowse now. Not sure what to do about the man pages for b2m, grep-changelog, and rcs-checkin. You might want to open a separate bug for them. Thanks --dan