From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog Date: Wed, 10 Dec 2008 08:31:13 -0800 (PST) Message-ID: <200812101631.mBAGVDwK025811@mothra.ics.uci.edu> References: <200812101546.mBAFkTpt025689@mothra.ics.uci.edu> <87vdts9fca.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228926722 1851 80.91.229.12 (10 Dec 2008 16:32:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2008 16:32:02 +0000 (UTC) Cc: Juanma Barranquero , Emacs Devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 17:33:06 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LARzR-0006ze-VW for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 17:32:46 +0100 Original-Received: from localhost ([127.0.0.1]:54852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LARyG-0002kV-J4 for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 11:31:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LARyC-0002k2-7h for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:31:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LARyA-0002jA-S4 for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:31:27 -0500 Original-Received: from [199.232.76.173] (port=54009 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LARyA-0002j3-9C for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:31:26 -0500 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:59574) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LARy9-00047H-Pz for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:31:26 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id mBAGVDpg009762; Wed, 10 Dec 2008 08:31:13 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBAGVDwK025811; Wed, 10 Dec 2008 08:31:13 -0800 (PST) In-Reply-To: <87vdts9fca.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed, 10 Dec 2008 11:15:17 -0500") Original-Lines: 25 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mBAGVDpg009762 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106757 Archived-At: Chong Yidong writes: > "Juanma Barranquero" writes: > > >> Not only is my taste not to add unneeded #defines, but the main > >> reason is that there's other code in src that deals with the daemon > >> that uses just fine #ifdef WINDOWSNT. Consistency in all directories > >> is important. > > > > That other code should also use EMACS_DAEMON or similar. > > That depends on the specifics of the situation. Could either you or Dan > point out the places in src that use WINDOWSNT to handle daemon mode, to > give us more information to work with? emacs.c: main uses DOS_NT (which is WINDOWSNT || MSDOS) emacclient.c is not used in DOS > Another thing to consider: does the Emacs server and daemon work on > Nextstep? Adrian has a patch to make it working on Cocoa (it's only needed because the daemon does a fork() and continues executing in the child, and the Cocoa libraries don't work in such a situation). From what I understood, the patch would no be needed on GNUStep.