From: Dan Nicolaescu <dann@ics.uci.edu>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com
Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c
Date: Wed, 3 Dec 2008 14:03:45 -0800 (PST) [thread overview]
Message-ID: <200812032203.mB3M3jGD028987@mothra.ics.uci.edu> (raw)
In-Reply-To: <f7ccd24b0812031308t4a94f04q9ea841ad1ffeeecd@mail.gmail.com> (Juanma Barranquero's message of "Wed, 3 Dec 2008 22:08:00 +0100")
"Juanma Barranquero" <lekktu@gmail.com> writes:
> On Wed, Dec 3, 2008 at 20:15, Dan Nicolaescu <dann@ics.uci.edu> wrote:
>
> > should only need a single #ifdef.
>
> Why?
Because it's simpler.
> > The clear precedent is that WINDOWSNT already encompasses a bazillion
> > features, why would a bazillion + 1 won't make any difference?
>
> As Eli pointed out, we should be moving towards decreasing the
> bazillion things conflated into #ifdef WINDOWSNT, not increasing them.
Good luck convincing anyone about that. There are 378 undocumented
macros in admin/CPP-DEFINES, and probably 1000-2000 in use in src/*,
increasing that number does not seem such a hot idea.
> > It would
> > make a difference for the vast majority of people that write to the
> > emacs repository, most do not use windows and can just ignore the #ifdef
> > WINDOWSNT code.
>
> Apparently it's not that confusing. There has been no complain until
> now from the people who's hacked on emacsclient.
This is not a valid proof. Maybe people didn't want to complain, or
didn't figure out the difference, etc.
> > On a not so related note, why are there #includes on line 671 in
> > emacsclient.c instead of at the beginning of the file?
>
> Because they affect code inside a big #else which goes from there to
> the end of the file.
>
> They were already there before the TCP socket support, indeed from
> version 1.1 of the file (though it was line 49 back then...)
Still not too good, and a deviation from the normal style of not having
includes in the middle of the file.
next prev parent reply other threads:[~2008-12-03 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 6:35 bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Dan Nicolaescu
2008-12-03 8:03 ` jasonr
2008-12-03 15:24 ` Dan Nicolaescu
2008-12-03 15:33 ` Juanma Barranquero
2008-12-03 19:15 ` Dan Nicolaescu
2008-12-03 21:08 ` Juanma Barranquero
2008-12-03 22:03 ` Dan Nicolaescu [this message]
2008-12-03 22:15 ` Juanma Barranquero
2008-12-03 23:51 ` Juanma Barranquero
2008-12-04 4:13 ` Eli Zaretskii
2011-07-04 11:34 ` Juanma Barranquero
2008-12-03 18:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812032203.mB3M3jGD028987@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=1483@emacsbugs.donarmstrong.com \
--cc=jasonr@f2s.com \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.