From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Date: Wed, 3 Dec 2008 11:15:04 -0800 (PST) Message-ID: <200812031915.mB3JF4ts026816@mothra.ics.uci.edu> References: <200812030635.mB36Z9mk024296@mothra.ics.uci.edu> <1228291406.49363d4ebc7d8@webmail.freedom2surf.net> <200812031524.mB3FOBqt025290@mothra.ics.uci.edu> Reply-To: Dan Nicolaescu , 1483@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228332721 10775 80.91.229.12 (3 Dec 2008 19:32:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2008 19:32:01 +0000 (UTC) Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 03 20:33:03 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7xSm-0001Kx-S8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 20:32:45 +0100 Original-Received: from localhost ([127.0.0.1]:33878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7xRc-0006J7-Lu for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 14:31:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7xQQ-0005gS-Vw for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 14:30:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7xQQ-0005fq-02 for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 14:30:18 -0500 Original-Received: from [199.232.76.173] (port=60443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7xQP-0005fl-Pe for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 14:30:17 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47449) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7xQP-0006V5-25 for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 14:30:17 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3JUDr2021578; Wed, 3 Dec 2008 11:30:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB3JP30Y019902; Wed, 3 Dec 2008 11:25:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 03 Dec 2008 19:25:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1483 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1483-submit@emacsbugs.donarmstrong.com id=B1483.122833172018470 (code B ref 1483); Wed, 03 Dec 2008 19:25:03 +0000 Original-Received: (at 1483) by emacsbugs.donarmstrong.com; 3 Dec 2008 19:15:20 +0000 Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3JFHMV017998 for <1483@emacsbugs.donarmstrong.com>; Wed, 3 Dec 2008 11:15:18 -0800 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mB3JF6HS005029; Wed, 3 Dec 2008 11:15:06 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mB3JF4ts026816; Wed, 3 Dec 2008 11:15:04 -0800 (PST) In-Reply-To: (Juanma Barranquero's message of "Wed, 3 Dec 2008 16:33:54 +0100") Original-Lines: 43 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mB3JF6HS005029 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 03 Dec 2008 14:30:18 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22918 Archived-At: "Juanma Barranquero" writes: > On Wed, Dec 3, 2008 at 16:24, Dan Nicolaescu wrote: > > > That's better than everyone else having to figure out the same thing > > until that hypothetical moment. > > There's nothing to figure right now: NO_SOCKETS_IN_FILE_SYSTEM is > self-descriptive. Code like this: struct option longopts[] = { { "no-wait", no_argument, NULL, 'n' }, { "eval", no_argument, NULL, 'e' }, { "help", no_argument, NULL, 'H' }, { "version", no_argument, NULL, 'V' }, { "tty", no_argument, NULL, 't' }, { "nw", no_argument, NULL, 't' }, { "create-frame", no_argument, NULL, 'c' }, { "alternate-editor", required_argument, NULL, 'a' }, { "retry-with-daemon", no_argument, NULL, 't' }, #ifndef NO_SOCKETS_IN_FILE_SYSTEM { "socket-name", required_argument, NULL, 's' }, #endif { "server-file", required_argument, NULL, 'f' }, #ifndef WINDOWSNT { "display", required_argument, NULL, 'd' }, #endif { 0, 0, 0, 0 } }; should only need a single #ifdef. The clear precedent is that WINDOWSNT already encompasses a bazillion features, why would a bazillion + 1 won't make any difference? It would make a difference for the vast majority of people that write to the emacs repository, most do not use windows and can just ignore the #ifdef WINDOWSNT code. On a not so related note, why are there #includes on line 671 in emacsclient.c instead of at the beginning of the file?