all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: emacs-devel@gnu.org
Subject: Problem report #130: base/src/emacs/src/xterm.c (x_draw_glyph_string); UNINIT
Date: Tue, 02 Dec 2008 17:16:29 -0800	[thread overview]
Message-ID: <200812030120.mB31KQRd022812@mothra.ics.uci.edu> (raw)

CID: 130
Checker: UNINIT (help)
File: base/src/emacs/src/xterm.c
Function: x_draw_glyph_string
Description: Using uninitialized value "position"

Event var_decl: Declared variable "position" without initializer
Also see events: [uninit_use]

2729 		  unsigned long thickness, position;
2730 		  int y;
2731 	

At conditional (1): "(s)->prev != 0" taking true path
At conditional (2): "(((s)->prev)->face)->underline_p != 0" taking false path

2732 		  if (s->prev && s->prev->face->underline_p)
2733 		    {
2734 		      /* We use the same underline style as the previous one.  */
2735 		      thickness = s->prev->underline_thickness;
2736 		      position = s->prev->underline_position;
2737 		    }
2738 		  else
2739 		    {
2740 		      /* Get the underline thickness.  Default is 1 pixel.  */

At conditional (3): "(s)->font != 0" taking false path

2741 		      if (s->font && s->font->underline_thickness > 0)
2742 			thickness = s->font->underline_thickness;
2743 		      else
2744 			thickness = 1;

At conditional (4): "x_underline_at_descent_line != 0" taking false path

2745 		      if (x_underline_at_descent_line)
2746 			position = (s->height - thickness) - (s->ybase - s->y);
2747 		      else
2748 			{
2749 			  /* Get the underline position.  This is the recommended
2750 			     vertical offset in pixels from the baseline to the top of
2751 			     the underline.  This is a signed value according to the
2752 			     specs, and its default is
2753 	
2754 			     ROUND ((maximum descent) / 2), with
2755 			     ROUND(x) = floor (x + 0.5)  */
2756 	

At conditional (5): "x_use_underline_position_properties != 0" taking true path
At conditional (6): "(s)->font != 0" taking false path

2757 			  if (x_use_underline_position_properties
2758 			      && s->font && s->font->underline_position >= 0)
2759 			    position = s->font->underline_position;

At conditional (7): "(s)->font != 0" taking false path

2760 			  else if (s->font)
2761 			    position = (s->font->descent + 1) / 2;
2762 			}

Event uninit_use: Using uninitialized value "position"
Also see events: [var_decl]

2763 		      position = max (position, underline_minimum_offset);
2764 		    }




             reply	other threads:[~2008-12-03  1:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03  1:16 Dan Nicolaescu [this message]
2008-12-03  4:12 ` Problem report #130: base/src/emacs/src/xterm.c (x_draw_glyph_string); UNINIT Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812030120.mB31KQRd022812@mothra.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.