From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Problem report #128: base/src/emacs/src/ftfont.c (ftfont_resolve_generic_family); UNINIT Date: Tue, 02 Dec 2008 17:05:53 -0800 Message-ID: <200812030120.mB31KN2I022809@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228267646 1991 80.91.229.12 (3 Dec 2008 01:27:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2008 01:27:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 02:28:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7gXS-0004d9-Q5 for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2008 02:28:27 +0100 Original-Received: from localhost ([127.0.0.1]:35996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7gWI-0007xE-Fq for ged-emacs-devel@m.gmane.org; Tue, 02 Dec 2008 20:27:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7gPw-0003RG-Lz for emacs-devel@gnu.org; Tue, 02 Dec 2008 20:20:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7gPu-0003P9-Jf for emacs-devel@gnu.org; Tue, 02 Dec 2008 20:20:39 -0500 Original-Received: from [199.232.76.173] (port=53390 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7gPu-0003Og-79 for emacs-devel@gnu.org; Tue, 02 Dec 2008 20:20:38 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:34587) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L7gPr-00005s-0p for emacs-devel@gnu.org; Tue, 02 Dec 2008 20:20:35 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mB31KNLK027034 for ; Tue, 2 Dec 2008 17:20:23 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mB31KN2I022809; Tue, 2 Dec 2008 17:20:23 -0800 (PST) Original-Lines: 73 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mB31KNLK027034 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106476 Archived-At: CID: 128 Checker: UNINIT (help) File: base/src/emacs/src/ftfont.c Function: ftfont_resolve_generic_family Description: Using uninitialized value "match" Event var_decl: Declared variable "match" without initializer Also see events: [uninit_use] 209 FcPattern *match; 210 FcResult result; 211 FcLangSet *langset; 212 213 family = Fintern (Fdowncase (SYMBOL_NAME (family)), Qnil); At conditional (1): "family == Qmono" taking true path 214 if (EQ (family, Qmono)) 215 family = Qmonospace; 216 else if (EQ (family, Qsans) || EQ (family, Qsans__serif)) 217 family = Qsans_serif; 218 slot = assq_no_quit (family, ftfont_generic_family_list); At conditional (2): "slot & 7 != 5" taking false path 219 if (! CONSP (slot)) 220 return Qnil; At conditional (3): "(0 + (((0), (slot & -8))->u).cdr) != Qt" taking false path 221 if (! EQ (XCDR (slot), Qt)) 222 return XCDR (slot); 223 pattern = FcPatternDuplicate (pattern); At conditional (4): "pattern == 0" taking true path 224 if (! pattern) 225 goto err; 226 FcPatternDel (pattern, FC_FOUNDRY); 227 FcPatternDel (pattern, FC_FAMILY); 228 FcPatternAddString (pattern, FC_FAMILY, SYMBOL_FcChar8 (family)); 229 if (FcPatternGetLangSet (pattern, FC_LANG, 0, &langset) != FcResultMatch) 230 { 231 /* This is to avoid the effect of locale. */ 232 langset = FcLangSetCreate (); 233 FcLangSetAdd (langset, "en"); 234 FcPatternAddLangSet (pattern, FC_LANG, langset); 235 FcLangSetDestroy (langset); 236 } 237 FcConfigSubstitute (NULL, pattern, FcMatchPattern); 238 FcDefaultSubstitute (pattern); 239 match = FcFontMatch (NULL, pattern, &result); 240 if (match) 241 { 242 FcChar8 *fam; 243 244 if (FcPatternGetString (match, FC_FAMILY, 0, &fam) == FcResultMatch) 245 family = intern ((char *) fam); 246 } 247 else 248 family = Qnil; 249 XSETCDR (slot, family); 250 err: Event uninit_use: Using uninitialized value "match" Also see events: [var_decl] 251 if (match) FcPatternDestroy (match); 252 if (pattern) FcPatternDestroy (pattern); 253 return family; 254 } 2