Problem report #116: base/src/emacs/src/fontset.c (face_for_char); UNINIT

Problem report #116: base/src/emacs/src/fontset.c (face_for_char); UNINIT

[Dan Nicolaescu]

CID: 116
Checker: UNINIT (help)
File: base/src/emacs/src/fontset.c
Function: face_for_char
Description: Using uninitialized value "id" in call to function "fontset_font"

867  	
868  	int
869  	face_for_char (f, face, c, pos, object)
870  	     FRAME_PTR f;
871  	     struct face *face;
872  	     int c, pos;
873  	     Lisp_Object object;
874  	{
875  	  Lisp_Object fontset, rfont_def, charset;
876  	  int face_id;

Event var_decl: Declared variable "id" without initializer
Also see events: [uninit_use_in_call]

877  	  int id;
878  	

At conditional (1): "c < 128" taking false path

879  	  if (ASCII_CHAR_P (c))
880  	    return face->ascii_face->id;
881  	
882  	  xassert (fontset_id_valid_p (face->fontset));
883  	  fontset = FONTSET_FROM_ID (face->fontset);
884  	  xassert (!BASE_FONTSET_P (fontset));
885  	

At conditional (2): "pos < 0" taking false path

886  	  if (pos < 0)
887  	    {
888  	      id = -1;
889  	      charset = Qnil;
890  	    }
891  	  else
892  	    {
893  	      charset = Fget_char_property (make_number (pos), Qcharset, object);

At conditional (3): "charset == Qnil" taking false path

894  	      if (NILP (charset))
895  		id = -1;

At conditional (4): "hash_lookup >= 0" taking false path

896  	      else if (CHARSETP (charset))
897  		{
898  		  Lisp_Object val;
899  	
900  		  val = assoc_no_quit (charset, Vfont_encoding_charset_alist);
901  		  if (CONSP (val) && CHARSETP (XCDR (val)))
902  		    charset = XCDR (val);
903  		  id = XINT (CHARSET_SYMBOL_ID (charset));
904  		}
905  	    }
906  	
907  	  font_deferred_log ("font for", Fcons (make_number (c), charset), Qnil);

Event uninit_use_in_call: Using uninitialized value "id" in call to function "fontset_font" [model]
Also see events: [var_decl]

908  	  rfont_def = fontset_font (fontset, c, face, id);
909  	  if (VECTORP (rfont_def))
910  	    {

Re: Problem report #116: base/src/emacs/src/fontset.c (face_for_char); UNINIT

[Kenichi Handa]

In article <200812030115.mB31Fqub022795@mothra.ics.uci.edu>, Dan Nicolaescu <dann@ics.uci.edu> writes:

> CID: 116
> Checker: UNINIT (help)
> File: base/src/emacs/src/fontset.c
> Function: face_for_char
> Description: Using uninitialized value "id" in call to function "fontset_font"

Fixed.

---
Kenichi Handa
handa@ni.aist.go.jp