From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juri Linkov <juri@jurta.org>, Tom Tromey <tromey@redhat.com>,
"T.V. Raman" <tv.raman.tv@gmail.com>,
emacs-devel@gnu.org, Miles Bader <miles@gnu.org>
Subject: Re: files.el: Patch to make project-settings optional/customizable
Date: Sun, 23 Nov 2008 00:10:06 -0800 (PST) [thread overview]
Message-ID: <200811230810.mAN8A6fp022636@mothra.ics.uci.edu> (raw)
In-Reply-To: <jwvd4gnc8si.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 23 Nov 2008 00:27:11 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > I agree it does feel like that, but still, making it a defconst seems
> > like the tasteful thing to do...
>
> We could make it read-only, like we do for t, nil, :toto, and
> enable-multibyte-characters.
Or just get rid of the defconst. Let's look at the code in question:
(defconst dir-locals-file ".dir-locals.el"
"File that contains directory-local variables.
It has to be constant to enforce uniform values
across different environments and users.")
(defun dir-locals-find-file (file)
"Find the directory-local variables FILE.
This searches upward in the directory tree.
If a local variables file is found, the file name is returned.
If the file is already registered, a cons from
`dir-locals-directory-alist' is returned.
Otherwise this returns nil."
(setq file (expand-file-name file))
(let ((locals-file (locate-dominating-file file dir-locals-file))
(dir-elt nil))
;; `locate-dominating-file' may have abbreviated the name.
(when locals-file
(setq locals-file (expand-file-name dir-locals-file locals-file)))
(dolist (elt dir-locals-directory-alist)
(when (and (eq t (compare-strings file nil (length (car elt))
(car elt) nil nil))
(> (length (car elt)) (length (car dir-elt))))
(setq dir-elt elt)))
(if (and locals-file dir-elt)
(if (> (length (file-name-directory locals-file))
(length (car dir-elt)))
locals-file
dir-elt)
(or locals-file dir-elt))))
So there are 2 uses .dir-locals.el 3 lines apart in the same 24 lines function.
The defconst adds 4 lines. It's hard to keep a straight face and claim
that the defconst is a good idea.
(and the 2 uses could be reduced to a single one if we make
locate-dominating-file return an expanded file name -- which seems to be
a good idea anyway).
It's kind of painful that this discussion is still going on, it should
have never occurred in the first place...
next prev parent reply other threads:[~2008-11-23 8:10 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 14:29 files.el: Patch to make project-settings optional/customizable T.V. Raman
2008-11-13 15:20 ` Chong Yidong
2008-11-13 16:07 ` Dan Nicolaescu
2008-11-13 16:19 ` Dan Nicolaescu
2008-11-13 16:45 ` Tom Tromey
2008-11-13 17:14 ` Chong Yidong
2008-11-13 17:28 ` Dan Nicolaescu
2008-11-13 17:55 ` Juanma Barranquero
2008-11-13 17:59 ` Dan Nicolaescu
2008-11-13 19:13 ` Juanma Barranquero
2008-11-13 19:00 ` Tom Tromey
2008-11-13 19:15 ` Juanma Barranquero
2008-11-13 18:26 ` Chong Yidong
2008-11-13 18:48 ` Dan Nicolaescu
2008-11-18 16:36 ` Dan Nicolaescu
2008-11-18 22:04 ` Juri Linkov
2008-11-18 22:15 ` Dan Nicolaescu
2008-11-18 22:42 ` Juanma Barranquero
2008-11-18 23:18 ` Dan Nicolaescu
2008-11-18 23:41 ` Juanma Barranquero
2008-11-18 22:59 ` Stefan Monnier
2008-11-18 23:31 ` Juri Linkov
2008-11-18 23:33 ` Chong Yidong
2008-11-18 23:41 ` Dan Nicolaescu
2008-11-18 23:50 ` Juanma Barranquero
2008-11-19 0:14 ` Dan Nicolaescu
2008-11-19 1:48 ` Chong Yidong
2008-11-19 8:26 ` Juanma Barranquero
2008-11-19 12:52 ` Richard M. Stallman
2008-11-18 23:37 ` Juanma Barranquero
2008-11-19 2:01 ` Stefan Monnier
2008-11-19 8:39 ` Juanma Barranquero
2008-11-19 13:27 ` Dan Nicolaescu
2008-11-19 22:45 ` Juri Linkov
2008-11-19 22:58 ` Tom Tromey
2008-11-20 2:18 ` Stefan Monnier
2008-11-22 19:08 ` Juri Linkov
2008-11-22 19:40 ` Dan Nicolaescu
2008-11-22 19:51 ` Juri Linkov
2008-11-22 20:20 ` Dan Nicolaescu
2008-11-22 22:03 ` Juanma Barranquero
2008-11-23 3:34 ` Miles Bader
2008-11-23 5:27 ` Stefan Monnier
2008-11-23 5:36 ` Juanma Barranquero
2008-11-23 5:58 ` Stefan Monnier
2008-11-23 8:10 ` Dan Nicolaescu [this message]
2008-11-23 10:45 ` Juri Linkov
2008-11-23 12:10 ` Dan Nicolaescu
2008-11-23 12:41 ` Juanma Barranquero
2008-11-23 17:16 ` Dan Nicolaescu
2008-11-23 17:45 ` Juanma Barranquero
2008-11-23 21:21 ` Dan Nicolaescu
2008-11-24 2:14 ` Stephen J. Turnbull
2008-11-24 3:06 ` Dan Nicolaescu
2008-11-24 5:35 ` Chong Yidong
2008-11-22 4:03 ` Kevin Rodgers
2008-11-19 4:07 ` Stephen J. Turnbull
2008-11-13 19:04 ` Tom Tromey
2008-11-13 19:23 ` Tom Tromey
2008-11-13 19:55 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811230810.mAN8A6fp022636@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tromey@redhat.com \
--cc=tv.raman.tv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.