From: Dan Nicolaescu <dann@ics.uci.edu>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: cyd@stupidchicken.com, Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: emacsclient's option decoding code
Date: Thu, 13 Nov 2008 07:45:29 -0800 (PST) [thread overview]
Message-ID: <200811131545.mADFjTVr010085@mothra.ics.uci.edu> (raw)
In-Reply-To: <f7ccd24b0811130100g5970b37an8dfbba99741f44f@mail.gmail.com> (Juanma Barranquero's message of "Thu, 13 Nov 2008 10:00:53 +0100")
"Juanma Barranquero" <lekktu@gmail.com> writes:
> On Wed, Nov 12, 2008 at 17:37, Juanma Barranquero <lekktu@gmail.com> wrote:
>
> OK, let's try to clear somewhat the issues.
>
> About these changes:
>
> > - Do I change term/w32-win.el to use ":0.0" as argument to `x-open-connection'?
> >
> > - If yes, do we leave `make-frame-on-display' as it stands now, i.e.
> > accepting any DISPLAY string as valid when called from Windows, or do
> > we change it to accept just ":0.0" for the time being? (I favor the
> > second, which is simpler and cleaner: it's just removing the recent
> > three-line patch by Chong.)
>
> The attached patch uses ":0.0" on Windows (which seems to be the
> preferred answer) and *removes* Window-specific code in
> `make-frame-on-display' (in fact, it removes also a tiny bit of
> X-specific code).
>
> It is still not possible to do "emacsclient -c my-file" on Windows
> because of the -c/-t problem, but that will have to wait for some
> consensus.
>
> It is OK to install this?
>
> Juanma
>
>
> 2008-11-13 Juanma Barranquero <lekktu@gmail.com>
>
> * frame.el (make-frame-on-display): Remove Windows-specific hack.
> Pass the current window-system to `make-frame', not a hard-coded `x'.
>
> * term/w32-win.el (w32-initialize-window-system): Use ":0.0" instead
> of "" to represent the Windows display.
>
>
> Index: lisp/frame.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/frame.el,v
> retrieving revision 1.289
> diff -u -2 -r1.289 frame.el
> --- lisp/frame.el 7 Nov 2008 14:52:04 -0000 1.289
> +++ lisp/frame.el 13 Nov 2008 08:48:28 -0000
> @@ -617,7 +617,4 @@
> (make-frame `((window-system . ns)
> (display . ,display) . ,parameters)))
> - ((eq system-type 'windows-nt)
> - ;; On Windows, ignore DISPLAY.
> - (make-frame parameters))
> (t
> (unless (string-match-p "\\`[^:]*:[0-9]+\\(\\.[0-9]+\\)?\\'" display)
> @@ -626,5 +623,5 @@
> (setq x-display-name display)
> (x-initialize-window-system))
> - (make-frame `((window-system . x)
> + (make-frame `((window-system . ,window-system)
This is suspicious. Does it work when doing
emacs -Q -nw -f server-start
emacsclient -c
Sorry, I haven't followed this long thread, so I don't know what
problems this is trying to fix. But given where we are in the release
process, it would be good if changes to the X code would be tested
on X in all possible scenarios.
next prev parent reply other threads:[~2008-11-13 15:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 14:04 emacsclient's option decoding code Eli Zaretskii
2008-11-02 2:13 ` Stefan Monnier
2008-11-02 21:45 ` Chong Yidong
2008-11-02 22:00 ` Juanma Barranquero
2008-11-02 23:18 ` Chong Yidong
2008-11-03 0:50 ` Juanma Barranquero
2008-11-03 4:14 ` Eli Zaretskii
2008-11-03 12:12 ` Juanma Barranquero
2008-11-03 20:06 ` Eli Zaretskii
2008-11-03 20:19 ` Chong Yidong
2008-11-04 4:20 ` Eli Zaretskii
2008-11-04 16:40 ` Chong Yidong
2008-11-06 11:56 ` Juanma Barranquero
2008-11-03 21:26 ` Juanma Barranquero
2008-11-04 4:19 ` Eli Zaretskii
2008-11-06 12:08 ` Juanma Barranquero
2008-11-07 9:53 ` Eli Zaretskii
2008-11-07 11:42 ` Juanma Barranquero
2008-11-07 11:47 ` Juanma Barranquero
2008-11-07 14:36 ` Eli Zaretskii
2008-11-07 14:42 ` Juanma Barranquero
2008-11-10 18:22 ` Juanma Barranquero
2008-11-10 18:36 ` Chong Yidong
2008-11-10 23:33 ` Juanma Barranquero
2008-11-11 4:09 ` Eli Zaretskii
2008-11-11 4:14 ` Chong Yidong
2008-11-11 21:16 ` Eli Zaretskii
2008-11-11 9:39 ` Juanma Barranquero
2008-11-11 15:37 ` Juanma Barranquero
2008-11-11 21:24 ` Eli Zaretskii
2008-11-11 23:36 ` Juanma Barranquero
2008-11-12 4:22 ` Eli Zaretskii
2008-11-12 9:41 ` Juanma Barranquero
2008-11-12 19:14 ` Eli Zaretskii
2008-11-12 21:05 ` Juanma Barranquero
2008-11-13 4:12 ` Eli Zaretskii
2008-11-13 8:34 ` Juanma Barranquero
2008-11-12 19:37 ` Eli Zaretskii
2008-11-12 2:31 ` Stefan Monnier
2008-11-12 9:33 ` Juanma Barranquero
2008-11-12 15:56 ` Stefan Monnier
2008-11-12 16:37 ` Juanma Barranquero
2008-11-12 17:13 ` Stefan Monnier
2008-11-13 1:16 ` Lennart Borgman
2008-11-13 4:18 ` Eli Zaretskii
2008-11-13 9:00 ` Juanma Barranquero
2008-11-13 15:45 ` Dan Nicolaescu [this message]
2008-11-13 16:05 ` Juanma Barranquero
2008-11-13 16:05 ` Juanma Barranquero
2008-11-13 16:08 ` Dan Nicolaescu
2008-11-12 19:36 ` Eli Zaretskii
2008-11-12 20:56 ` Stefan Monnier
2008-11-13 4:10 ` Eli Zaretskii
2008-11-13 4:29 ` mail
2008-11-13 20:54 ` Eli Zaretskii
2008-11-13 21:27 ` mail
2008-11-13 22:30 ` Eli Zaretskii
2008-11-13 23:54 ` mail
2008-11-13 20:03 ` Juri Linkov
2008-11-13 20:40 ` mail
2008-11-13 21:08 ` Thorsten Bonow
2008-11-13 22:01 ` Thorsten Bonow
2008-11-15 2:58 ` Evil Boris
2008-11-07 14:35 ` Eli Zaretskii
2008-11-03 14:45 ` Juanma Barranquero
2008-11-03 19:59 ` Eli Zaretskii
2008-11-03 20:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811131545.mADFjTVr010085@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.