From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 23:09:35 -0800 (PST) Message-ID: <200811130709.mAD79ZoN009164@mothra.ics.uci.edu> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> <86tzacg8yc.fsf@lifelogs.com> <200811121956.mACJugiW007492@mothra.ics.uci.edu> <86ej1gfwop.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226560202 16214 80.91.229.12 (13 Nov 2008 07:10:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2008 07:10:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 13 08:11:04 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0WM2-0005lB-RT for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 08:11:03 +0100 Original-Received: from localhost ([127.0.0.1]:56614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0WKu-0000Q9-C6 for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 02:09:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0WKq-0000Q3-Ls for emacs-devel@gnu.org; Thu, 13 Nov 2008 02:09:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0WKl-0000Pq-NH for emacs-devel@gnu.org; Thu, 13 Nov 2008 02:09:48 -0500 Original-Received: from [199.232.76.173] (port=34903 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0WKl-0000Pn-K5 for emacs-devel@gnu.org; Thu, 13 Nov 2008 02:09:43 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:36276) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L0WKl-0003lz-58 for emacs-devel@gnu.org; Thu, 13 Nov 2008 02:09:43 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mAD79aLJ016731; Wed, 12 Nov 2008 23:09:36 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mAD79ZoN009164; Wed, 12 Nov 2008 23:09:35 -0800 (PST) In-Reply-To: <86ej1gfwop.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 12 Nov 2008 15:42:30 -0600") Original-Lines: 60 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mAD79aLJ016731 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105630 Archived-At: Ted Zlatanov writes: > On Wed, 12 Nov 2008 11:56:42 -0800 (PST) Dan Nicolaescu wrote: > > DN> Ted Zlatanov writes: > >> On Tue, 11 Nov 2008 17:11:06 -0800 (PST) Dan Nicolaescu wrote: > >> > DN> If you are interested in improving this area, please also look at one of > DN> the TODO items in vc.el: > >> > DN> ;; - When vc-next-action calls vc-checkin it could pre-fill the > DN> ;; *VC-log* buffer with some obvious items: the list of files that > DN> ;; were added, the list of files that were removed. If the diff is > DN> ;; available, maybe it could even call something like > DN> ;; `diff-add-change-log-entries-other-window' to create a detailed > DN> ;; skeleton for the log... > DN> ;; > >> > >> I think that should be up to the user, to be done in the hook. > > DN> Sure, but it would be nice to provide a way to do it by default. > > I think we agree that something is good, but it will be hard to agree on > the particulars of what to put in the buffer. So maybe the answer is a > format-like string (falling back to a function call) that the user can > customize? Or a list of functions? > >> The information, diff and files added/removed/affected, exists > >> outside the commit message so putting it inside the message > >> duplicates the information. > > DN> It exists, but it means you have to look in two places for it, it is > DN> customary to put such information in the logs. > > Sorry, I don't see what you mean. Putting it in the logs would ensure > you have two places to look, and when it's inaccurate it would be an > even worse situation. See many the logs for many GNU projects (including emacs), file addition and deletions are noted there, it's quite usual to do so. > DN> Also you only addressed one part of that TODO entry, the whole point is > DN> to make it easier to write log entries, and provide as much as possible > DN> by default. > > The two goals diverge significantly once the threshold of "enough" > information is passed, and unfortunately that is a different point for > every user. > > Specifically regarding the detailed skeleton, I think we're getting to > the format string/function concept I mentioned above. I don't think > Emacs has a default way to do this, but skeleton.el should work. IMHO the ChangeLog format * filename (FUNCTION_NAME): should be enough for the start, we'll see if users ask for a different format. The format is probably not that important for the beginning...