From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Tue, 11 Nov 2008 17:11:06 -0800 (PST) Message-ID: <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226452297 26801 80.91.229.12 (12 Nov 2008 01:11:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2008 01:11:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 12 02:12:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L04Hb-0000N6-Gw for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 02:12:35 +0100 Original-Received: from localhost ([127.0.0.1]:54995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L04GT-0005cU-BW for ged-emacs-devel@m.gmane.org; Tue, 11 Nov 2008 20:11:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L04GO-0005cP-1n for emacs-devel@gnu.org; Tue, 11 Nov 2008 20:11:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L04GL-0005c0-Q4 for emacs-devel@gnu.org; Tue, 11 Nov 2008 20:11:18 -0500 Original-Received: from [199.232.76.173] (port=58727 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L04GL-0005bx-Je for emacs-devel@gnu.org; Tue, 11 Nov 2008 20:11:17 -0500 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:42146) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L04GL-0004t9-GG for emacs-devel@gnu.org; Tue, 11 Nov 2008 20:11:17 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mAC1B6OC007077; Tue, 11 Nov 2008 17:11:10 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mAC1B6h1005596; Tue, 11 Nov 2008 17:11:06 -0800 (PST) In-Reply-To: <86od0mgcz5.fsf@lifelogs.com> (Ted Zlatanov's message of "Tue, 11 Nov 2008 15:38:22 -0600") Original-Lines: 58 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mAC1B6OC007077 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105589 Archived-At: Ted Zlatanov writes: > On Tue, 11 Nov 2008 11:45:32 -0800 (PST) Dan Nicolaescu wrote: > > DN> Ted Zlatanov writes: > >> On Tue, 11 Nov 2008 08:58:34 -0800 (PST) Dan Nicolaescu wrote: > > DN> It could and it should, just nobody has done the work yet to do it... > DN> If you are interested, it can be done `vc-checkin' by initializing the > DN> `initial-contents' parameter before the call to `vc-start-log-entry'. > >> > >> Wouldn't it be easier to do it by calling the function directly? > > DN> Not sure what your question is... What I described is one way to > DN> initialize the contents of the *VC-log* buffer. > > There's a function that will do it (`C-c C-a' == > log-edit-insert-changelog), I'm trying to find out if it's easier to > always call that function when setting up the *VC-log* buffer than use > initial-contents as you suggested. It seems so to me, and Stefan > suggested it too. Sorry, I don't know which version would be easier. If you are interested in improving this area, please also look at one of the TODO items in vc.el: ;; - When vc-next-action calls vc-checkin it could pre-fill the ;; *VC-log* buffer with some obvious items: the list of files that ;; were added, the list of files that were removed. If the diff is ;; available, maybe it could even call something like ;; `diff-add-change-log-entries-other-window' to create a detailed ;; skeleton for the log... ;; > >> Or do you mean I can insert the commented lines I suggested as well > >> that way? > > DN> If you add those comments, you'd need to add some post-processing to > DN> make sure they get removed before checking in, so it might not be the > DN> best idea. > > It's for user convenience, so I think it's a good idea. It's just > modifying log-edit-done at the beginning--it already does removal of > trailing empty lines, so this is pretty easy. Simply go to point-min > and then remove all the lines that match "^;;;". I can write and test > it unless you or someone else think it's a problem. If you are going to add the ChangeLog entries by default, then why bother with adding the text ? IMO adding text is inconvenient to users: they either have to read it, or they might think they have to delete it so that it does not get checked in. It would be nice to be able to insert text that is not part of the buffer, like in the header line, but that is a single line unfortunately :-(