From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1058: 23.0.60; emacs --daemon should not return until socket is ready Date: Mon, 27 Oct 2008 00:04:07 -0700 (PDT) Message-ID: <200810270704.m9R747nG020937@mothra.ics.uci.edu> References: <1222782234_2281@mail.internode.on.net> <200810011651.m91GpAZQ010333@mothra.ics.uci.edu> <87k5csds03.fsf@elegiac.orebokech.com> <200810012332.m91NWJ4s014658@mothra.ics.uci.edu> <874p3vediy.fsf@elegiac.orebokech.com> <200810020814.m928Ed1C016380@mothra.ics.uci.edu> <200810021726.m92HQcTQ017644@mothra.ics.uci.edu> <200810022234.m92MYgYp018688@mothra.ics.uci.edu> <200810130203.m9D23eul000572@mothra.ics.uci.edu> <200810131701.m9DH1ItS002005@mothra.ics.uci.edu> <200810140726.m9E7QHeb004332@mothra.ics.uci.edu> Reply-To: Dan Nicolaescu , 1058@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225092635 6070 80.91.229.12 (27 Oct 2008 07:30:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Oct 2008 07:30:35 +0000 (UTC) Cc: trentbuck@gmail.com, Romain Francoise To: 1058@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 27 08:31:36 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KuMZb-0000SX-Ea for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Oct 2008 08:31:36 +0100 Original-Received: from localhost ([127.0.0.1]:36956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuMYS-0005ib-Ng for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Oct 2008 03:30:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KuMYO-0005iW-TF for bug-gnu-emacs@gnu.org; Mon, 27 Oct 2008 03:30:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KuMYM-0005iJ-Do for bug-gnu-emacs@gnu.org; Mon, 27 Oct 2008 03:30:19 -0400 Original-Received: from [199.232.76.173] (port=58415 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuMYM-0005iG-6X for bug-gnu-emacs@gnu.org; Mon, 27 Oct 2008 03:30:18 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:12681) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KuMYL-0000X1-6E for bug-gnu-emacs@gnu.org; Mon, 27 Oct 2008 03:30:17 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KuMYI-0008Ty-NN for bug-gnu-emacs@gnu.org; Mon, 27 Oct 2008 03:30:15 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9R7U2ja016407; Mon, 27 Oct 2008 00:30:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9R7A4Hs011860; Mon, 27 Oct 2008 00:10:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 27 Oct 2008 07:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1058 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1058-submit@emacsbugs.donarmstrong.com id=B1058.12250910869828 (code B ref 1058); Mon, 27 Oct 2008 07:10:04 +0000 Original-Received: (at 1058) by emacsbugs.donarmstrong.com; 27 Oct 2008 07:04:46 +0000 Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9R74h2B009822 for <1058@emacsbugs.donarmstrong.com>; Mon, 27 Oct 2008 00:04:44 -0700 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9R748BD003195; Mon, 27 Oct 2008 00:04:13 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9R747nG020937; Mon, 27 Oct 2008 00:04:07 -0700 (PDT) In-Reply-To: <200810140726.m9E7QHeb004332@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 14 Oct 2008 00:26:17 -0700 (PDT)") Original-Lines: 38 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9R748BD003195 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Mon, 27 Oct 2008 03:30:19 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21937 Archived-At: Dan Nicolaescu writes: > Stefan Monnier writes: > > > >> > -(defun server-start (&optional leave-dead) > > >> > +(defun server-start (&optional leave-dead server-arg) > > >> > "Allow this Emacs process to be a server for client processes. > > >> > This starts a server communications subprocess through which > > >> > client \"editors\" can send your editing commands to this Emacs > > >> > @@ -463,6 +463,8 @@ kill any existing server communications > > >> > (when server-process > > >> > ;; kill it dead! > > >> > (ignore-errors (delete-process server-process))) > > >> > + (when (stringp server-arg) > > >> > + (setq server-name server-arg)) > > >> > > >> Changing the global var like this is an ugly hack. > > > > > Sure, it can be moved before the call to `sever-start' > > > I also wanted to make that variable obsolete and make the functional > > > interface the preferred method. > > > > There's no need or reason to make it obsolete. You basically want to > > replace the last two lines above with > > > > (unless (stringp server-arg) > > (setq server-arg server-name)) > > > > and then pass server-arg where it's needed. > > Ah, OK. I had the impression that server-name was needed for other > functions to work correctly, but that is not the case. > Updated patch follows. > > Now it's your choice if you want this patch now or later. I'll update > the docs when checking it in. I checked in a version of this changed as requested by Stefan.