From: Dan Nicolaescu <dann@ics.uci.edu>
To: Ali Bahrami <ali_gnu@emvision.com>
Cc: 1191@emacsbugs.donarmstrong.com
Subject: bug#1191: How to contribute back changes for Emacs on Solaris
Date: Thu, 23 Oct 2008 16:06:14 -0700 (PDT) [thread overview]
Message-ID: <200810232306.m9NN6ELs011000@mothra.ics.uci.edu> (raw)
In-Reply-To: <49010007.2000607@emvision.com> (Ali Bahrami's message of "Thu, 23 Oct 2008 16:51:51 -0600")
Ali Bahrami <ali_gnu@emvision.com> writes:
> Dan Nicolaescu wrote:
> > Ali Bahrami <ali_gnu@emvision.com> writes:
> >
> > > Dan,
> > > > I made the changes you suggested to the
> > src/s/sol2-10.h. I
> > > pulled a copy of CVS head, and produced diffs for configure.in based
> > > on that. Both items are below, delimited by '=======' lines.
> >
> > Thanks, I checked this in, with some simplifications.
> >
> > > =========================================================================
> > > *** configure.in.orig Wed Oct 22 20:40:42 2008
> > > --- configure.in Wed Oct 22 20:53:20 2008
> > > ***************
> > > *** 442,449 ****
> > > ;;
> > > > *-sun-solaris* \
> > > ! | i[3456]86-*-solaris2* | i[3456]86-*-sunos5* | powerpc*-*-solaris2* \
> > > ! | rs6000-*-solaris2*)
> > > case "${canonical}" in
> > > i[3456]86-*-* ) machine=intel386 ;;
> > > amd64-*-*|x86_64-*-*) machine=amdx86-64 ;;
> > > --- 442,450 ----
> > > ;;
> > > > *-sun-solaris* \
> > > ! | i[3456]86-*-solaris2* | i[3456]86-*-sunos5* \
> > > ! | x86_64-*-solaris2* | x86_64-*-sunos5* \
> > > ! | powerpc*-*-solaris2* | rs6000-*-solaris2*)
> >
> > This hunk should not be necessary, *-sun-solaris* should match anyway.
> > Please verify that things still work.
>
> Dan,
>
> src/s/sol2-10.h is fine. There are some issues with the changes to
> configure though.
>
> The hunk you removed really is needed, at least the 'x86_64-*-solaris2*' part.
> I put the 'x86_64-*-sunos5*' one in because it mirror how the 32-bit one
> above is defined, but the 'x86_64-*-solaris2*' is needed to get a build.
>
> The reason '*-sun-solaris*' isn't sufficient is that on X86
> hardware, the "vendor" is not "sun":
>
> % ./config.guess
> i386-pc-solaris2.11
> % CC='gcc -m64' ./config.guess
> amd64-solaris2.11
^^^^^^^^^^^^^^^^^^
This does not look right, it needs to be a triplet, not a pair, so amd64-pc-solaris2.11
But I'll wait until your config.guess changes are checked in.
It's actually quite surprising that config.guess did not support for
amd64/x86_64 on Solaris...
> There is a typo (missing ;; in a case statement), and the clause
> for Solaris 7-9 fails because a bit got missed.
Thanks. Fixed.
> I'm going to show the part of the file I modified here, and mark the
> modified lines with a '>' in column 1.
BTW, context or unified diffs are preferred here.
next prev parent reply other threads:[~2008-10-23 23:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812120309.mBC392kD002742@mothra.ics.uci.edu>
2008-10-17 3:44 ` bug#1191: How to contribute back changes for Emacs on Solaris Ali Bahrami
2008-10-17 6:22 ` Dan Nicolaescu
2008-10-17 16:27 ` Ali Bahrami
2008-10-17 23:52 ` Dan Nicolaescu
2008-10-19 3:18 ` Ali Bahrami
2008-10-20 22:29 ` Dan Nicolaescu
2008-10-23 6:45 ` Ali Bahrami
2008-10-23 16:23 ` Ali Bahrami
2008-10-23 19:35 ` Dan Nicolaescu
2008-10-23 22:51 ` Ali Bahrami
2008-10-23 23:06 ` Dan Nicolaescu [this message]
2008-10-23 23:21 ` Ali Bahrami
2008-10-24 0:22 ` Dan Nicolaescu
2008-12-11 17:47 ` Dan Nicolaescu
2008-12-11 18:10 ` Ali Bahrami
2008-12-11 18:14 ` Dan Nicolaescu
2008-12-11 18:21 ` Ali Bahrami
2008-12-12 2:55 ` Ali Bahrami
2008-12-12 3:15 ` bug#1191: marked as done (How to contribute back changes for Emacs on Solaris) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810232306.m9NN6ELs011000@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=1191@emacsbugs.donarmstrong.com \
--cc=ali_gnu@emvision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.