From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: vc-git-show-log-entry Date: Mon, 20 Oct 2008 15:10:10 -0700 (PDT) Message-ID: <200810202210.m9KMAALe025685@mothra.ics.uci.edu> References: <200810201819.m9KIJ6Wh024634@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224544705 23535 80.91.229.12 (20 Oct 2008 23:18:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Oct 2008 23:18:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Karl Chen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 21 01:19:25 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ks2yV-0005xE-VP for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 00:11:44 +0200 Original-Received: from localhost ([127.0.0.1]:51594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ks2xQ-00084N-Hy for ged-emacs-devel@m.gmane.org; Mon, 20 Oct 2008 18:10:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ks2xM-00083u-HJ for emacs-devel@gnu.org; Mon, 20 Oct 2008 18:10:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ks2xJ-00082j-Ph for emacs-devel@gnu.org; Mon, 20 Oct 2008 18:10:31 -0400 Original-Received: from [199.232.76.173] (port=39250 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ks2xJ-00082g-ND for emacs-devel@gnu.org; Mon, 20 Oct 2008 18:10:29 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:55703) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1Ks2xI-00083N-V2 for emacs-devel@gnu.org; Mon, 20 Oct 2008 18:10:29 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9KMAAYx025927; Mon, 20 Oct 2008 15:10:10 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9KMAALe025685; Mon, 20 Oct 2008 15:10:10 -0700 (PDT) In-Reply-To: (Karl Chen's message of "Mon, 20 Oct 2008 13:20:37 -0700") Original-Lines: 39 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9KMAAYx025927 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104704 Archived-At: Karl Chen writes: > >>>>> On 2008-10-20 11:19 PDT, Dan Nicolaescu writes: > > Dan> Karl Chen writes: > >> visiting a git-versioned file, when I do `vc-print-log', > >> point always moves to the end of the buffer instead of the > >> beginning. > > Dan> It's hard to say what problem you are trying to report. > > Dan> Can you please try again with a step by step description > Dan> of what you are doing, what are the results you are > Dan> getting and what are the expected results. Please start > Dan> from emacs -Q Please use emacs from CVS HEAD. It's > Dan> unlikely that another release will be made from the 22.x > Dan> branch. > > git init > date > f1 ; git add *; git commit -m commit1 > date >> f1 ; git add *; git commit -m commit2 > emacs -Q f1 > C-x C-v l I assume this is: C-x v l > ; point moves to the end of the *vc-change-log* buffer instead of > ; the beginning. It moves to the beginning for me. What version of emacs are you using? > As I said, if you undo the latest commit to vc-git.el, that fixes > it, but I suggest this replacement altogether. > > (defun vc-git-show-log-entry (rev) > (log-view-goto-rev (vc-git-rev-parse rev))) Not sure if adding yet another git invocation here is a good idea. Please run your change by Alexandre Julliard.