From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1191: How to contribute back changes for Emacs on Solaris Date: Thu, 16 Oct 2008 23:22:44 -0700 (PDT) Message-ID: <200810170622.m9H6Mipv013865@mothra.ics.uci.edu> References: <48F80A14.7010502@emvision.com> Reply-To: Dan Nicolaescu , 1191@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224226218 6412 80.91.229.12 (17 Oct 2008 06:50:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Oct 2008 06:50:18 +0000 (UTC) Cc: 1191@emacsbugs.donarmstrong.com To: Ali Bahrami Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 17 08:51:18 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqjB7-00061b-T2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Oct 2008 08:51:18 +0200 Original-Received: from localhost ([127.0.0.1]:50883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqjA2-0000KF-Oj for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Oct 2008 02:50:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kqj9y-0000KA-H1 for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 02:50:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kqj9v-0000Jy-Qi for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 02:50:05 -0400 Original-Received: from [199.232.76.173] (port=60333 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kqj9v-0000Je-Kz for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 02:50:03 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:17565) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kqj9v-0002Zm-00 for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 02:50:03 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kqj9u-0007RC-1h for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 02:50:02 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9H6o0BI006209; Thu, 16 Oct 2008 23:50:00 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9H6U3u7001495; Thu, 16 Oct 2008 23:30:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 17 Oct 2008 06:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1191 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1191-submit@emacsbugs.donarmstrong.com id=B1191.122422459132734 (code B ref 1191); Fri, 17 Oct 2008 06:30:03 +0000 Original-Received: (at 1191) by emacsbugs.donarmstrong.com; 17 Oct 2008 06:23:11 +0000 Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9H6N8s3032728 for <1191@emacsbugs.donarmstrong.com>; Thu, 16 Oct 2008 23:23:09 -0700 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9H6Mj3O029142; Thu, 16 Oct 2008 23:22:48 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9H6Mipv013865; Thu, 16 Oct 2008 23:22:44 -0700 (PDT) In-Reply-To: <48F80A14.7010502@emvision.com> (Ali Bahrami's message of "Thu, 16 Oct 2008 21:44:20 -0600") Original-Lines: 78 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9H6Mj3O029142 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Fri, 17 Oct 2008 02:50:05 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21583 Archived-At: Ali Bahrami writes: > This message is a follow up to one I sent to emacs-devel > last July: > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html > > The question had to do with why emacs wasn't using dldump() > to produce the dumped executable under Solaris. It had been using it > up until 2002, at which point it was commented out, and it wasn't > clear why. No one knew the reason, and the consensus was "try it and see". > > Since then, I've done some work to integrate emacs with > OpenSolaris as a standard package. I turned on dldump(), > and have been using the emacs binaries built with it daily > since July without issue. > > So now, I have some things I'd like to send back up stream > and get integrated into the emacs distribution: > > - Man pages for things installed to /usr/bin that didn't > already have a manpage: > b2m.1 > ebrowse.1 > grep-changelog.1 > rcs-checkin.1 > - Small changes to config.guess and configure to properly > detect amd64 hardware running Solaris. > - Use dldump() instead of the generic ELF dump code > under Solaris. > - Use the system malloc under Solaris (at least with > amd64, emacs crashes without this). > > The manpages can be viewed at: > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1 > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1 Hopefully someone else can address these changes, I'll address the rest. > and the patches at: > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch Please send this one to config-patches@gnu.org. We don't modify this file directly in emacs, it gets updated from time to time from: http://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.guess > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch This one is fine, but it depends on the previous one being installed by the config.guess maintainers. BTW, do you know anything about emacs running on powerpc*-*-solaris2* or rs6000-*-solaris2* ? configure.in mentions them. > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch Last time when you posted this you said you were going to test it on multiple Solaris versions. Have you managed to do that? This is also valid for the next patch. > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch > > The patches are for emacs 22.1. I've examined 22.3, and the > changes are applicable there as well. If 22.1 diffs are OK, > that's easiest for me, but if not, then please let me know what > I need to supply. These diffs are all very short, affecting a > small number of lines in each file. AFAIK the 22.x branch is closed, there will not be any more releases from that branch. But we could install your changes on HEAD. Thanks --dan