bug#1191: How to contribute back changes for Emacs on Solaris

[Dan Nicolaescu <dann@ics.uci.edu>]

Ali Bahrami <ali_gnu@emvision.com> writes:

  > This message is a follow up to one I sent to emacs-devel
  > last July:
  > 
  > 	http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html
  > 
  > The question had to do with why emacs wasn't using dldump()
  > to produce the dumped executable under Solaris. It had been using it
  > up until 2002, at which point it was commented out, and it wasn't
  > clear why. No one knew the reason, and the consensus was "try it and see".
  > 
  > Since then, I've done some work to integrate emacs with
  > OpenSolaris as a standard package. I turned on dldump(),
  > and have been using the emacs binaries built with it daily
  > since July without issue.
  > 
  > So now, I have some things I'd like to send back up stream
  > and get integrated into the emacs distribution:
  > 
  > 	- Man pages for things installed to /usr/bin that didn't
  > 	  already have a manpage:
  > 		b2m.1
  > 		ebrowse.1
  > 		grep-changelog.1
  > 		rcs-checkin.1
  > 	- Small changes to config.guess and configure to properly
  > 	  detect amd64 hardware running Solaris.
  > 	- Use dldump() instead of the generic ELF dump code
  > 	  under Solaris.
  > 	- Use the system malloc under Solaris (at least with
  > 	  amd64, emacs crashes without this).
  > 
  > The manpages can be viewed at:
  > 
  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1
  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1
  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1
  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1

Hopefully someone else can address these changes, I'll address the rest.

  > and the patches at:
  > 
  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch

Please send this one to config-patches@gnu.org.
We don't modify this file directly in emacs, it gets updated from time
to time from:
http://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.guess

  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch

This one is fine, but it depends on the previous one being installed by
the config.guess maintainers.
BTW, do you know anything about emacs running on  powerpc*-*-solaris2*
or  rs6000-*-solaris2* ? configure.in mentions them.

  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch

Last time when you posted this you said you were going to test it on
multiple Solaris versions.  Have you managed to do that?  This is also
valid for the next patch.

  > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch
  > 
  > The patches are for emacs 22.1. I've examined 22.3, and the
  > changes are applicable there as well. If 22.1 diffs are OK,
  > that's easiest for me, but if not, then please let me know what
  > I need to supply. These diffs are all very short, affecting a
  > small number of lines in each file.

AFAIK the 22.x branch is closed, there will not be any more releases
from that branch.  But we could install your changes on HEAD.

Thanks

        --dan