From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: SuperH port Date: Wed, 15 Oct 2008 14:36:41 -0700 (PDT) Message-ID: <200810152136.m9FLafBH009918@mothra.ics.uci.edu> References: <18668.31387.21197.719443@a1ihome1.kph.uni-mainz.de> <200810081431.m98EVuUJ011805@mothra.ics.uci.edu> <18668.64085.372743.905358@a1ihome1.kph.uni-mainz.de> <18678.23984.801356.890460@a1ihome1.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224106674 7471 80.91.229.12 (15 Oct 2008 21:37:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Oct 2008 21:37:54 +0000 (UTC) Cc: sh@gentoo.org, emacs@gentoo.org, Stefan Monnier , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 15 23:38:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqE4D-0001N1-82 for ged-emacs-devel@m.gmane.org; Wed, 15 Oct 2008 23:38:05 +0200 Original-Received: from localhost ([127.0.0.1]:48675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqE38-0001ov-HK for ged-emacs-devel@m.gmane.org; Wed, 15 Oct 2008 17:36:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqE32-0001jn-TP for emacs-devel@gnu.org; Wed, 15 Oct 2008 17:36:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqE32-0001iO-6o for emacs-devel@gnu.org; Wed, 15 Oct 2008 17:36:52 -0400 Original-Received: from [199.232.76.173] (port=34965 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqE32-0001i8-1f for emacs-devel@gnu.org; Wed, 15 Oct 2008 17:36:52 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:57386) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KqE31-0002gR-Rp for emacs-devel@gnu.org; Wed, 15 Oct 2008 17:36:52 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9FLafl2010177; Wed, 15 Oct 2008 14:36:42 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9FLafBH009918; Wed, 15 Oct 2008 14:36:41 -0700 (PDT) In-Reply-To: <18678.23984.801356.890460@a1ihome1.kph.uni-mainz.de> (Ulrich Mueller's message of "Wed, 15 Oct 2008 23:16:32 +0200") Original-Lines: 61 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9FLafl2010177 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104537 Archived-At: Ulrich Mueller writes: > >>>>> On Wed, 08 Oct 2008, Stefan Monnier wrote: > > > This port is wanted. Thank you for your effort to bring it back to > > life. Could someone install his change (and clean it up where > > appropriate)? > > Please find an updated patch below, addressing most of Dan's > criticism: > > - Support for NetBSD and OpenBSD has been removed since its status is > unknown. > - Definitions of EXPLICIT_SIGN_EXTEND, VIRT_ADDR_VARIES and other > unneccessary macros have been deleted. > > However, I've left both files m/sh3el.h and m/sh3eb.h in for now, Please don't, we already have a precedent on how to do this, inventing yet another style just creates more work for when things are going to be cleaned up later to use an autoconf test. Isn't there a symbol that the compiler defines differently for big/little endian? See what mips.h does: #if ! (defined (__MIPSEL__) || defined (MIPSEL) || defined (_MIPSEL)) #define WORDS_BIG_ENDIAN #endif > +SuperH (sh[34]*-*-linux-gnu) > + > + Emacs 23.0.60 was reported to work on GNU/Linux (October 2008). > + Tested on a little-endian sh4 system (cpu type SH7751R) running > + Gentoo Linux 2008.0. No big endian testing? > --- emacs-orig/src/m/sh3el.h 1970-01-01 01:00:00.000000000 +0100 > +++ emacs/src/m/sh3el.h 2008-10-01 07:20:41.000000000 +0200 > @@ -0,0 +1,31 @@ > +/* machine description file for little-endian SuperH. > + Copyright (C) 1985, 1986, 2006, 2007, 2008 Free Software Foundation, Inc. > + > +This file is part of GNU Emacs. > + > +GNU Emacs is free software: you can redistribute it and/or modify > +it under the terms of the GNU General Public License as published by > +the Free Software Foundation, either version 3 of the License, or > +(at your option) any later version. > + > +GNU Emacs is distributed in the hope that it will be useful, > +but WITHOUT ANY WARRANTY; without even the implied warranty of > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +GNU General Public License for more details. > + > +You should have received a copy of the GNU General Public License > +along with GNU Emacs. If not, see . */ No need for the copyright notice, the file is just 2 lines of code, it would become 4 with the endianess test.