Re: SuperH port

[Dan Nicolaescu <dann@ics.uci.edu>]

Ulrich Mueller <ulm@gentoo.org> writes:

  > >>>>> On Wed, 08 Oct 2008, Stefan Monnier wrote:
  > 
  > > This port is wanted.  Thank you for your effort to bring it back to
  > > life.  Could someone install his change (and clean it up where
  > > appropriate)?
  > 
  > Please find an updated patch below, addressing most of Dan's
  > criticism:
  > 
  > - Support for NetBSD and OpenBSD has been removed since its status is
  >   unknown.
  > - Definitions of EXPLICIT_SIGN_EXTEND, VIRT_ADDR_VARIES and other
  >   unneccessary macros have been deleted.
  > 
  > However, I've left both files m/sh3el.h and m/sh3eb.h in for now,

Please don't, we already have a precedent on how to do this, inventing
yet another style just creates more work for when things are going to be
cleaned up later to use an autoconf test.

Isn't there a symbol that the compiler defines differently for
big/little endian?  See what mips.h does:

#if ! (defined (__MIPSEL__) || defined (MIPSEL) || defined (_MIPSEL))
#define WORDS_BIG_ENDIAN
#endif


  > +SuperH (sh[34]*-*-linux-gnu)
  > +
  > +  Emacs 23.0.60 was reported to work on GNU/Linux (October 2008).
  > +  Tested on a little-endian sh4 system (cpu type SH7751R) running
  > +  Gentoo Linux 2008.0.

No big endian testing?

  > --- emacs-orig/src/m/sh3el.h	1970-01-01 01:00:00.000000000 +0100
  > +++ emacs/src/m/sh3el.h	2008-10-01 07:20:41.000000000 +0200
  > @@ -0,0 +1,31 @@
  > +/* machine description file for little-endian SuperH.
  > +   Copyright (C) 1985, 1986, 2006, 2007, 2008  Free Software Foundation, Inc.
  > +
  > +This file is part of GNU Emacs.
  > +
  > +GNU Emacs is free software: you can redistribute it and/or modify
  > +it under the terms of the GNU General Public License as published by
  > +the Free Software Foundation, either version 3 of the License, or
  > +(at your option) any later version.
  > +
  > +GNU Emacs is distributed in the hope that it will be useful,
  > +but WITHOUT ANY WARRANTY; without even the implied warranty of
  > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  > +GNU General Public License for more details.
  > +
  > +You should have received a copy of the GNU General Public License
  > +along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */

No need for the copyright notice, the file is just 2 lines of code, it
would become 4 with the endianess test.