bug#1067: 23.0.60; vc-dir (git): doesn't update "branch" line

bug#1067: 23.0.60; vc-dir (git): doesn't update "branch" line

[Eric Hanchrow]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

* I started Emacs in a git working tree, whose checked-out branch was
  named "master":

    $ cd /usr/local/src/emacs-via-git/src
    $ git branch
    * master
    $ ./emacs -Q -nw

* I ran vc-dir by typing C-x v d, and noticed that the output was
  correct: in particular, it said "Branch : master"

* I created, and switched to, a new branch, by typing 

    M-! git checkout -b fred RET

* I "refreshed" the *vc-dir* buffer by typing g ("revert-buffer").  I
  noticed that it _still_ said "Branch : master".  This is the bug; I
  expected to see "Branch : fred".

* I killed the *vc-dir* buffer with C-x k RET, then recreated it with
  C-x v d.  This time, I saw "Branch : fred", as I expected.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/src/emacs-via-git/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.19 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-09-28 on debian
configured using `configure  '--enable-maintainer-mode' '--with-xpm=yes' '--with-jpeg=no' '--with-gif=no' '--with-tiff=no' '--with-xft' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f d r TAB RET ESC x r e p o r TAB RET

Recent messages:
("./emacs" "-Q")
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-git...done

-- 
Unix ... is not so much a product as it is a painstakingly compiled
oral history of the hacker subculture.  It is our Gilgamesh epic.
        -- Neal Stephenson

bug#1067: 23.0.60; vc-dir (git): doesn't update "branch" line

[Dan Nicolaescu]

Eric Hanchrow <offby1@blarg.net> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > * I started Emacs in a git working tree, whose checked-out branch was
  >   named "master":
  > 
  >     $ cd /usr/local/src/emacs-via-git/src
  >     $ git branch
  >     * master
  >     $ ./emacs -Q -nw
  > 
  > * I ran vc-dir by typing C-x v d, and noticed that the output was
  >   correct: in particular, it said "Branch : master"
  > 
  > * I created, and switched to, a new branch, by typing 
  > 
  >     M-! git checkout -b fred RET
  > 
  > * I "refreshed" the *vc-dir* buffer by typing g ("revert-buffer").  I
  >   noticed that it _still_ said "Branch : master".  This is the bug; I
  >   expected to see "Branch : fred".
  > 
  > * I killed the *vc-dir* buffer with C-x k RET, then recreated it with
  >   C-x v d.  This time, I saw "Branch : fred", as I expected.

`vc-dir-refresh' needs to recompute the header for vc-ewoc (i.e. run
(vc-dir-headers vc-dir-backend default-directory) )
and put the result back in the ewoc.

Do you want to take a stab at it?

bug#1067: marked as done (23.0.60; vc-dir (git): doesn't update "branch" line)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Your message dated Sat, 13 Dec 2008 09:57:51 -0800 (PST)
with message-id <200812131757.mBDHvpbc009303@mothra.ics.uci.edu>
and subject line Re: bug#1067: 23.0.60; vc-dir (git): doesn't update "branch" line
has caused the Emacs bug report #1067,
regarding 23.0.60; vc-dir (git): doesn't update "branch" line
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1067: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1067
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4937 bytes --]

From: Eric Hanchrow <offby1@blarg.net>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; vc-dir (git): doesn't update "branch" line
Date: Thu, 02 Oct 2008 13:54:13 -0700
Message-ID: <87k5cqogzu.fsf@offby1.atm01.sea.blarg.net>


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

* I started Emacs in a git working tree, whose checked-out branch was
  named "master":

    $ cd /usr/local/src/emacs-via-git/src
    $ git branch
    * master
    $ ./emacs -Q -nw

* I ran vc-dir by typing C-x v d, and noticed that the output was
  correct: in particular, it said "Branch : master"

* I created, and switched to, a new branch, by typing 

    M-! git checkout -b fred RET

* I "refreshed" the *vc-dir* buffer by typing g ("revert-buffer").  I
  noticed that it _still_ said "Branch : master".  This is the bug; I
  expected to see "Branch : fred".

* I killed the *vc-dir* buffer with C-x k RET, then recreated it with
  C-x v d.  This time, I saw "Branch : fred", as I expected.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/src/emacs-via-git/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.19 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-09-28 on debian
configured using `configure  '--enable-maintainer-mode' '--with-xpm=yes' '--with-jpeg=no' '--with-gif=no' '--with-tiff=no' '--with-xft' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f d r TAB RET ESC x r e p o r TAB RET

Recent messages:
("./emacs" "-Q")
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-git...done

-- 
Unix ... is not so much a product as it is a painstakingly compiled
oral history of the hacker subculture.  It is our Gilgamesh epic.
        -- Neal Stephenson



[-- Attachment #3: Type: message/rfc822, Size: 2023 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: 1067-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1067: 23.0.60; vc-dir (git): doesn't update "branch" line
Date: Sat, 13 Dec 2008 09:57:51 -0800 (PST)
Message-ID: <200812131757.mBDHvpbc009303@mothra.ics.uci.edu>

Fixed on  2008-10-03.