From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#1052: segfault when resuming emacsclient -t in an xterm Date: Tue, 30 Sep 2008 11:18:16 -0700 (PDT) Message-ID: <200809301818.m8UIIGFf003951@mothra.ics.uci.edu> References: <873ajho96t.fsf@cyd.mit.edu> Reply-To: Dan Nicolaescu , 1052@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222799422 9207 80.91.229.12 (30 Sep 2008 18:30:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2008 18:30:22 +0000 (UTC) Cc: 1052@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 20:31:16 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kkk0B-0001uC-Uw for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2008 20:31:16 +0200 Original-Received: from localhost ([127.0.0.1]:37887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kkjz9-0002tY-1I for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2008 14:30:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kkjz2-0002sm-E4 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 14:30:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kkjyz-0002ri-Sx for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 14:30:03 -0400 Original-Received: from [199.232.76.173] (port=56170 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kkjyz-0002rZ-Ki for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 14:30:01 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56782) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kkjyy-0006wM-AB for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 14:30:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8UITt0H006094; Tue, 30 Sep 2008 11:29:55 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8UIP3Np005011; Tue, 30 Sep 2008 11:25:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 30 Sep 2008 18:25:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1052 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1052-submit@emacsbugs.donarmstrong.com id=B1052.12227987523680 (code B ref 1052); Tue, 30 Sep 2008 18:25:03 +0000 Original-Received: (at 1052) by emacsbugs.donarmstrong.com; 30 Sep 2008 18:19:12 +0000 Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8UIJ9mQ003673 for <1052@emacsbugs.donarmstrong.com>; Tue, 30 Sep 2008 11:19:10 -0700 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m8UIIHNq000778; Tue, 30 Sep 2008 11:18:21 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m8UIIGFf003951; Tue, 30 Sep 2008 11:18:16 -0700 (PDT) In-Reply-To: <873ajho96t.fsf@cyd.mit.edu> (Chong Yidong's message of "Tue, 30 Sep 2008 13:06:02 -0400") Original-Lines: 44 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m8UIIHNq000778 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 30 Sep 2008 14:30:03 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20924 Archived-At: Chong Yidong writes: > > The problem is that after the cited change > > `xterm-remove-modify-other-keys' calls `terminal-live-p' (it was > > previously using `frame-live-p') before calling > > `send-string-to-terminal'. > > > > `terminal-live-p' does not return false when tty->output is NULL ---> > > KABOOM. > > Looks like it's just a matter of checking tty->output, then. WDYT? Not sure it's a good idea. The test for `frame-live-p' was trying to make sure that the frame is OK and `send-string-to-terminal' would work. Not sure 1. why was it replaced with `terminal-live-p' 2. maybe `terminal-live-p' needs to be changed to detect this condition > *** trunk/src/dispnew.c.~1.419.~ 2008-09-28 16:09:43.000000000 -0400 > --- trunk/src/dispnew.c 2008-09-30 13:02:21.000000000 -0400 > *************** > *** 6470,6477 **** > fwrite (SDATA (string), 1, SBYTES (string), tty->termscript); > fflush (tty->termscript); > } > ! fwrite (SDATA (string), 1, SBYTES (string), tty->output); > ! fflush (tty->output); > UNBLOCK_INPUT; > return Qnil; > } > --- 6470,6480 ---- > fwrite (SDATA (string), 1, SBYTES (string), tty->termscript); > fflush (tty->termscript); > } > ! if (tty->output) > ! { > ! fwrite (SDATA (string), 1, SBYTES (string), tty->output); > ! fflush (tty->output); > ! } > UNBLOCK_INPUT; > return Qnil; > }