From: Dan Nicolaescu <dann@ics.uci.edu>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 1052@emacsbugs.donarmstrong.com
Subject: bug#1052: segfault when resuming emacsclient -t in an xterm
Date: Tue, 30 Sep 2008 11:18:16 -0700 (PDT) [thread overview]
Message-ID: <200809301818.m8UIIGFf003951@mothra.ics.uci.edu> (raw)
In-Reply-To: <873ajho96t.fsf@cyd.mit.edu> (Chong Yidong's message of "Tue, 30 Sep 2008 13:06:02 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> > The problem is that after the cited change
> > `xterm-remove-modify-other-keys' calls `terminal-live-p' (it was
> > previously using `frame-live-p') before calling
> > `send-string-to-terminal'.
> >
> > `terminal-live-p' does not return false when tty->output is NULL --->
> > KABOOM.
>
> Looks like it's just a matter of checking tty->output, then. WDYT?
Not sure it's a good idea.
The test for `frame-live-p' was trying to make sure that the frame is OK
and `send-string-to-terminal' would work.
Not sure
1. why was it replaced with `terminal-live-p'
2. maybe `terminal-live-p' needs to be changed to detect this condition
> *** trunk/src/dispnew.c.~1.419.~ 2008-09-28 16:09:43.000000000 -0400
> --- trunk/src/dispnew.c 2008-09-30 13:02:21.000000000 -0400
> ***************
> *** 6470,6477 ****
> fwrite (SDATA (string), 1, SBYTES (string), tty->termscript);
> fflush (tty->termscript);
> }
> ! fwrite (SDATA (string), 1, SBYTES (string), tty->output);
> ! fflush (tty->output);
> UNBLOCK_INPUT;
> return Qnil;
> }
> --- 6470,6480 ----
> fwrite (SDATA (string), 1, SBYTES (string), tty->termscript);
> fflush (tty->termscript);
> }
> ! if (tty->output)
> ! {
> ! fwrite (SDATA (string), 1, SBYTES (string), tty->output);
> ! fflush (tty->output);
> ! }
> UNBLOCK_INPUT;
> return Qnil;
> }
next prev parent reply other threads:[~2008-09-30 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 17:06 bug#1052: segfault when resuming emacsclient -t in an xterm Chong Yidong
2008-09-30 18:18 ` Dan Nicolaescu [this message]
2008-09-30 22:06 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2008-09-29 17:46 Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809301818.m8UIIGFf003951@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=1052@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.