bug#427: 23.0.60; emacsclient -t not working within "less"

bug#427: 23.0.60; emacsclient -t not working within "less"

[Andreas Amann]

1) start emacs with "emacs -q -f server-start &"
2) export VISUAL="emacsclient -t"
2) less .bashrc
3) within less type "v" to edit file with $VISUAL 

the result is that less writes a line 
"!emacsclient -t +18 .bashrc" on the terminal, but other than that the 
terminal is still showing the output of less. emacsclient 
is not taking over the terminal, and no editing is possible. 

Using "ps auxw" in another terminal, emacsclient appears in the
process list, though.  The only thing I can do in the "less terminal"
is to type "C-c" to resume viewing the .bashrc file.

The problem seems to be specific to "emacsclient -t", since both
export VISUAL="emacsclient -c"
and 
export VISUAL="emacs -nw"
work as expected.

The same problem occurs in both xterm and konsole. 




In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-06-11 on lnx0015f2465ec6
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/home/aamann/local/emacs-cvs' 'LDFLAGS=-L/home/aamann/local/lib64' 'CPPFLAGS=-I/home/aamann/local/include''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_IE.utf8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC [ > 0 ; 1 1 5 ; 0 c C-x C-c ESC [ > 0 ; 1 1 5 ; 
0 c ESC [ > 0 ; 1 1 5 ; 0 c M-x b u <tab> <backspace> 
<backspace> <backspace> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
When done with this frame, type C-x 5 0
(No files need saving)
When done with this frame, type C-x 5 0 [2 times]
Making completion list...
call-interactively: Text is read-only
Quit

23.0.60; emacsclient -t not working within "less"

[Chong Yidong]

From bug 427:

> 1) start emacs with "emacs -q -f server-start &"
> 2) export VISUAL="emacsclient -t"
> 2) less .bashrc
> 3) within less type "v" to edit file with $VISUAL 
>
> the result is that less writes a line "!emacsclient -t +18 .bashrc" on
> the terminal, but other than that the terminal is still showing the
> output of less. emacsclient is not taking over the terminal, and no
> editing is possible.

This looks like a serious bug that needs to be addressed.  Does anyone
have a clue about how to fix/debug this?

bug#427: 23.0.60; emacsclient -t not working within "less"

[Dan Nicolaescu]

Chong Yidong <cyd@stupidchicken.com> writes:

  > From bug 427:
  > 
  > > 1) start emacs with "emacs -q -f server-start &"
  > > 2) export VISUAL="emacsclient -t"
  > > 2) less .bashrc
  > > 3) within less type "v" to edit file with $VISUAL 
  > >
  > > the result is that less writes a line "!emacsclient -t +18 .bashrc" on
  > > the terminal, but other than that the terminal is still showing the
  > > output of less. emacsclient is not taking over the terminal, and no
  > > editing is possible.
  > 
  > This looks like a serious bug that needs to be addressed.  Does anyone
  > have a clue about how to fix/debug this?

You can edebug `server-process-filter'.  Doing that shows quickly the
problem: emacsclient passes the tty as: -tty /dev/tty.
/dev/tty means one thing for emacsclient and another one for emacs...

emacsclient.c computes the tty like this:

      tty_name = ttyname (fileno (stdin));

changing it to:

      tty_name = ttyname (fileno (stdout));

gets the right terminal and this problem seems to be fixed.

Re: 23.0.60; emacsclient -t not working within "less"

[Dan Nicolaescu]

Chong Yidong <cyd@stupidchicken.com> writes:

  > From bug 427:
  > 
  > > 1) start emacs with "emacs -q -f server-start &"
  > > 2) export VISUAL="emacsclient -t"
  > > 2) less .bashrc
  > > 3) within less type "v" to edit file with $VISUAL 
  > >
  > > the result is that less writes a line "!emacsclient -t +18 .bashrc" on
  > > the terminal, but other than that the terminal is still showing the
  > > output of less. emacsclient is not taking over the terminal, and no
  > > editing is possible.
  > 
  > This looks like a serious bug that needs to be addressed.  Does anyone
  > have a clue about how to fix/debug this?

You can edebug `server-process-filter'.  Doing that shows quickly the
problem: emacsclient passes the tty as: -tty /dev/tty.
/dev/tty means one thing for emacsclient and another one for emacs...

emacsclient.c computes the tty like this:

      tty_name = ttyname (fileno (stdin));

changing it to:

      tty_name = ttyname (fileno (stdout));

gets the right terminal and this problem seems to be fixed.

Re: 23.0.60; emacsclient -t not working within "less"

[Chong Yidong]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> You can edebug `server-process-filter'.  Doing that shows quickly the
> problem: emacsclient passes the tty as: -tty /dev/tty.
> /dev/tty means one thing for emacsclient and another one for emacs...
>
> emacsclient.c computes the tty like this:
>
>       tty_name = ttyname (fileno (stdin));
>
> changing it to:
>
>       tty_name = ttyname (fileno (stdout));
>
> gets the right terminal and this problem seems to be fixed.

That seems to work fine for me too.  I checked in the fix.  Thanks.

bug#427: marked as done (23.0.60; emacsclient -t not working within "less")

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]


Your message dated Fri, 19 Sep 2008 11:51:09 -0400
with message-id <87bpykkuc2.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; emacsclient -t not working within "less"
has caused the Emacs bug report #427,
regarding 23.0.60; emacsclient -t not working within "less"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
427: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=427
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5052 bytes --]

From: Andreas Amann <andreas.amann@web.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; emacsclient -t not working within "less"
Date: Mon, 16 Jun 2008 11:32:44 +0100
Message-ID: <200806161032.m5GAWiVl004483@localhost.localdomain>


1) start emacs with "emacs -q -f server-start &"
2) export VISUAL="emacsclient -t"
2) less .bashrc
3) within less type "v" to edit file with $VISUAL 

the result is that less writes a line 
"!emacsclient -t +18 .bashrc" on the terminal, but other than that the 
terminal is still showing the output of less. emacsclient 
is not taking over the terminal, and no editing is possible. 

Using "ps auxw" in another terminal, emacsclient appears in the
process list, though.  The only thing I can do in the "less terminal"
is to type "C-c" to resume viewing the .bashrc file.

The problem seems to be specific to "emacsclient -t", since both
export VISUAL="emacsclient -c"
and 
export VISUAL="emacs -nw"
work as expected.

The same problem occurs in both xterm and konsole. 




In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-06-11 on lnx0015f2465ec6
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/home/aamann/local/emacs-cvs' 'LDFLAGS=-L/home/aamann/local/lib64' 'CPPFLAGS=-I/home/aamann/local/include''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_IE.utf8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC [ > 0 ; 1 1 5 ; 0 c C-x C-c ESC [ > 0 ; 1 1 5 ; 
0 c ESC [ > 0 ; 1 1 5 ; 0 c M-x b u <tab> <backspace> 
<backspace> <backspace> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
When done with this frame, type C-x 5 0
(No files need saving)
When done with this frame, type C-x 5 0 [2 times]
Making completion list...
call-interactively: Text is read-only
Quit



[-- Attachment #3: Type: message/rfc822, Size: 1843 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org, Andreas Amann <andreas.amann@web.de>, 427-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; emacsclient -t not working within "less"
Date: Fri, 19 Sep 2008 11:51:09 -0400
Message-ID: <87bpykkuc2.fsf@cyd.mit.edu>

Dan Nicolaescu <dann@ics.uci.edu> writes:

> You can edebug `server-process-filter'.  Doing that shows quickly the
> problem: emacsclient passes the tty as: -tty /dev/tty.
> /dev/tty means one thing for emacsclient and another one for emacs...
>
> emacsclient.c computes the tty like this:
>
>       tty_name = ttyname (fileno (stdin));
>
> changing it to:
>
>       tty_name = ttyname (fileno (stdout));
>
> gets the right terminal and this problem seems to be fixed.

That seems to work fine for me too.  I checked in the fix.  Thanks.

Re: 23.0.60; emacsclient -t not working within "less"

[Eli Zaretskii]

> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Fri, 19 Sep 2008 11:51:09 -0400
> Cc: 427-done@emacsbugs.donarmstrong.com, Andreas Amann <andreas.amann@web.de>,
> 	emacs-devel@gnu.org
> 
> Dan Nicolaescu <dann@ics.uci.edu> writes:
> 
> > You can edebug `server-process-filter'.  Doing that shows quickly the
> > problem: emacsclient passes the tty as: -tty /dev/tty.
> > /dev/tty means one thing for emacsclient and another one for emacs...
> >
> > emacsclient.c computes the tty like this:
> >
> >       tty_name = ttyname (fileno (stdin));
> >
> > changing it to:
> >
> >       tty_name = ttyname (fileno (stdout));
> >
> > gets the right terminal and this problem seems to be fixed.
> 
> That seems to work fine for me too.  I checked in the fix.  Thanks.

Yes, but is this the right fix?  The `tty' command prints "/dev/tty"
as well in the situation described by the original bug report.  Why
doesn't Emacs DTRT with that name?  Can it fail in a similar way with
the name of the device connected to stdout?