bug#909: not finding etc/charsets/ should give some error/warning

bug#909: not finding etc/charsets/ should give some error/warning

[Dan Nicolaescu]

Currently if etc/charsets/ is not found at runtime no warning/error
is shown.  Not having that directory results in strange behavior, and we
have had a few instances of such problems reported to the list.

It would be great if some warning/error would be shown if etc/charsets/*
is not found.

bug#909: not finding etc/charsets/ should give some error/warning

[Glenn Morris]

Dan Nicolaescu wrote:

> It would be great if some warning/error would be shown if
> etc/charsets/* is not found.

*** charset.c	3 Jun 2008 04:22:55 -0000	1.163
--- charset.c	10 Sep 2008 21:00:06 -0000
***************
*** 2044,2052 ****
  void
  init_charset ()
  {
!   Vcharset_map_path
!     = Fcons (Fexpand_file_name (build_string ("charsets"), Vdata_directory),
! 	     Qnil);
  }
  
  
--- 2044,2055 ----
  void
  init_charset ()
  {
!   Lisp_Object tempdir;
!   tempdir = Fexpand_file_name (build_string ("charsets"), Vdata_directory);
!   if (access (SDATA (tempdir), 0) < 0)
!     dir_warning ("Warning: charsets directory (%s) does not exist.\n",
! 		 tempdir);
! 
!   Vcharset_map_path = Fcons (tempdir, Qnil);
  }
  

bug#909: not finding etc/charsets/ should give some error/warning

[Dan Nicolaescu]

Glenn Morris <rgm@gnu.org> writes:

  > Dan Nicolaescu wrote:
  > 
  > > It would be great if some warning/error would be shown if
  > > etc/charsets/* is not found.
  > 
  > *** charset.c	3 Jun 2008 04:22:55 -0000	1.163
  > --- charset.c	10 Sep 2008 21:00:06 -0000
  > ***************
  > *** 2044,2052 ****
  >   void
  >   init_charset ()
  >   {
  > !   Vcharset_map_path
  > !     = Fcons (Fexpand_file_name (build_string ("charsets"), Vdata_directory),
  > ! 	     Qnil);
  >   }
  >   
  >   
  > --- 2044,2055 ----
  >   void
  >   init_charset ()
  >   {
  > !   Lisp_Object tempdir;
  > !   tempdir = Fexpand_file_name (build_string ("charsets"), Vdata_directory);
  > !   if (access (SDATA (tempdir), 0) < 0)
  > !     dir_warning ("Warning: charsets directory (%s) does not exist.\n",
  > ! 		 tempdir);

Thanks.

How about saying something like "Emacs will not function correctly in
this condition", or something of the sort, to emphasize that the
situation is quite bad?

bug#909: not finding etc/charsets/ should give some error/warning

[Glenn Morris]

Dan Nicolaescu wrote:

> How about saying something like "Emacs will not function correctly in
> this condition", or something of the sort, to emphasize that the
> situation is quite bad?

Should it cause an abort?

bug#909: not finding etc/charsets/ should give some error/warning

[Andreas Schwab]

Glenn Morris <rgm@gnu.org> writes:

> Dan Nicolaescu wrote:
>
>> How about saying something like "Emacs will not function correctly in
>> this condition", or something of the sort, to emphasize that the
>> situation is quite bad?
>
> Should it cause an abort?

It's an external condition that Emacs has no control over (it could be a
temporary NFS problem, for example).  Just aborting does not give any
clue what is wrong.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#909: not finding etc/charsets/ should give some error/warning

[Glenn Morris]

Andreas Schwab wrote:

> It's an external condition that Emacs has no control over (it could be a
> temporary NFS problem, for example).  Just aborting does not give any
> clue what is wrong.

I meant: after a helpful, descriptive error message is printed, should
Emacs continue to run, or is this problem so severe that it should
refuse to start?

bug#909: marked as done (not finding etc/charsets/ should give some error/warning)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]


Your message dated Thu, 11 Sep 2008 23:10:59 -0400
with message-id <34iqt2jby4.fsf@fencepost.gnu.org>
and subject line Re: bug#909: not finding etc/charsets/ should give some error/warning
has caused the Emacs bug report #909,
regarding not finding etc/charsets/ should give some error/warning
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
909: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=909
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2481 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs@gnu.org>
Subject: not finding etc/charsets/ should give some error/warning
Date: Sun, 07 Sep 2008 04:19:28 -0700
Message-ID: <200809071119.m87BJSoB026156@sallyv1.ics.uci.edu>


Currently if etc/charsets/ is not found at runtime no warning/error
is shown.  Not having that directory results in strange behavior, and we
have had a few instances of such problems reported to the list.

It would be great if some warning/error would be shown if etc/charsets/*
is not found.




[-- Attachment #3: Type: message/rfc822, Size: 1811 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 909-done@emacsbugs.donarmstrong.com
Cc: Andreas Schwab <schwab@suse.de>, Dan Nicolaescu <dann@ics.uci.edu>
Subject: Re: bug#909: not finding etc/charsets/ should give some error/warning
Date: Thu, 11 Sep 2008 23:10:59 -0400
Message-ID: <34iqt2jby4.fsf@fencepost.gnu.org>


I've installed a (louder) warning. Someone can make it exit if they wish.