From: Dan Nicolaescu <dann@ics.uci.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: 910@emacsbugs.donarmstrong.com
Subject: bug#910: leim-list.el is looked up in too many places at startup
Date: Tue, 09 Sep 2008 19:19:05 -0700 [thread overview]
Message-ID: <200809100219.m8A2J5Cl011266@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <xv8wu03gfe.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 09 Sep 2008 22:04:05 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Dan Nicolaescu wrote:
>
> > strace emacs -Q
> >
> > shows that leim-list.el is looked up in 32 locations at startup. We
> > only have it in a single place. Is this a leftover from the time
> > when leim was distributed separately from emacs?
> >
> > It would be good if this redundant work would be avoided.
>
>
> It does seem superfluous. This works for me:
Thanks!
> *** startup.el 23 Aug 2008 16:59:19 -0000 1.503
> --- startup.el 10 Sep 2008 02:03:52 -0000
> ***************
> *** 478,496 ****
> ;; Look in each dir in load-path for a subdirs.el file.
> ;; If we find one, load it, which will add the appropriate subdirs
> ;; of that dir into load-path,
> - ;; Look for a leim-list.el file too. Loading it will register
> - ;; available input methods.
> (let ((tail load-path) dir)
> (while tail
> (setq dir (car tail))
> (let ((default-directory dir))
> (load (expand-file-name "subdirs.el") t t t))
> - (let ((default-directory dir))
> - (load (expand-file-name "leim-list.el") t t t))
> ;; We don't use a dolist loop and we put this "setq-cdr" command at
> ;; the end, because the subdirs.el files may add elements to the end
> ;; of load-path and we want to take it into account.
> (setq tail (cdr tail))))
> ;; If the PWD environment variable isn't accurate, delete it.
> (let ((pwd (getenv "PWD")))
> (and (stringp pwd)
> --- 478,501 ----
> ;; Look in each dir in load-path for a subdirs.el file.
> ;; If we find one, load it, which will add the appropriate subdirs
> ;; of that dir into load-path,
> (let ((tail load-path) dir)
> (while tail
> (setq dir (car tail))
> (let ((default-directory dir))
> (load (expand-file-name "subdirs.el") t t t))
> ;; We don't use a dolist loop and we put this "setq-cdr" command at
> ;; the end, because the subdirs.el files may add elements to the end
> ;; of load-path and we want to take it into account.
> (setq tail (cdr tail))))
> + ;; Look for a leim-list.el file. Loading it will register
> + ;; available input methods.
> + (let ((leim (expand-file-name "../leim/leim-list.el" data-directory)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This won't work when building in a separate directory:
leim-list.el is generated in the build tree, not the
source tree (unlike what happens for .elc files...)
next prev parent reply other threads:[~2008-09-10 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 11:25 bug#910: leim-list.el is looked up in too many places at startup Dan Nicolaescu
2008-09-10 2:04 ` Glenn Morris
2008-09-10 2:19 ` Dan Nicolaescu [this message]
2008-09-10 4:33 ` Glenn Morris
2008-09-10 6:50 ` Glenn Morris
2008-09-10 8:11 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2009-10-23 5:37 Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809100219.m8A2J5Cl011266@sallyv1.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=910@emacsbugs.donarmstrong.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.