From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug#636: Please fix before the release of 23.1 Date: Wed, 13 Aug 2008 09:24:55 +0000 Message-ID: <20080813092455.GB3010@muc.de> References: <871w1xfmsb.fsf@grepfind.mwolson.org> <87ljzj3oad.fsf_-_@grepfind.mwolson.org> <18590.45488.891078.545308@a1ihome1.kph.uni-mainz.de> <18590.47471.82980.734389@a1ihome1.kph.uni-mainz.de> <87ljz45xfj.fsf@stupidchicken.com> <18591.59359.40969.641357@a1ihome1.kph.uni-mainz.de> <87fxpb5xbn.fsf@stupidchicken.com> <20080811190124.GB28138@muc.de> <87bpzzfcu9.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218619451 18400 80.91.229.12 (13 Aug 2008 09:24:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Aug 2008 09:24:11 +0000 (UTC) Cc: 636-done@emacsbugs.donarmstrong.com, Glenn Morris , Ulrich Mueller , Michael Olson , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 13 11:25:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KTCb4-0006la-9K for ged-emacs-devel@m.gmane.org; Wed, 13 Aug 2008 11:24:50 +0200 Original-Received: from localhost ([127.0.0.1]:59505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTCa6-00060z-Mq for ged-emacs-devel@m.gmane.org; Wed, 13 Aug 2008 05:23:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTCZU-0005cW-0W for emacs-devel@gnu.org; Wed, 13 Aug 2008 05:23:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTCZK-0005UV-FY for emacs-devel@gnu.org; Wed, 13 Aug 2008 05:23:02 -0400 Original-Received: from [199.232.76.173] (port=50877 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTCZE-0005TK-Ms for emacs-devel@gnu.org; Wed, 13 Aug 2008 05:22:56 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:1502 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTCZD-0001wU-C0 for emacs-devel@gnu.org; Wed, 13 Aug 2008 05:22:55 -0400 Original-Received: (qmail 68768 invoked by uid 3782); 13 Aug 2008 09:22:52 -0000 Original-Received: from acm.muc.de (pD9E23735.dip.t-dialin.net [217.226.55.53]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Wed, 13 Aug 2008 11:22:50 +0200 Original-Received: (qmail 3176 invoked by uid 1000); 13 Aug 2008 09:24:55 -0000 Content-Disposition: inline In-Reply-To: <87bpzzfcu9.fsf@stupidchicken.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102400 Archived-At: Hi, Yidong! On Mon, Aug 11, 2008 at 05:42:22PM -0400, Chong Yidong wrote: > Alan Mackenzie writes: > > The way I see it, it's a bug in `beginning-of-defun'. The docstring > > says that a non-nil `beginning-of-defun-function' finds the pertinent > > place, but beginning-of-defun then moves point somewhere else. I > > HATE things that are ostensibly "helpful", but in reality are dumbing > > down, and mainly just foul things up. > This is part of the baggage in beginning-of-defun regarding whether > column zero is the beginning of a defun. Changing this now might be > unwise, so for the moment I've simply revised the docstring of > beginning-of-defun for extra clarity. Thanks! > I've also changed cc-defs.el to use beginning-of-defun-raw, which is a > more direct and side-effect free test of beginning-of-defun-function, > and added a save-excursion for extra plus safety ;-) I've just added a bit to bind mark-ring, because BOD adds a mark. I'm not actually convinced that using bod-raw is a good idea, since it feels like using an internal interface (which we might want to refactor away later). But it's not that big a deal, so I've left it. > [Also, closing bug#636.] :-) -- Alan Mackenzie (Nuremberg, Germany).