From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin Date: Sun, 03 Aug 2008 21:02:29 -0700 Message-ID: <200808040402.m7442ThQ023968@sallyv1.ics.uci.edu> References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> <200808040120.m741K6YQ001518@sallyv1.ics.uci.edu> <200808040226.m742QOgN023296@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217822628 6289 80.91.229.12 (4 Aug 2008 04:03:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2008 04:03:48 +0000 (UTC) Cc: Adrian Robert , Emanuele Giaquinta , Emacs Development To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 04 06:04:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPrJE-0001SB-Ou for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2008 06:04:37 +0200 Original-Received: from localhost ([127.0.0.1]:54360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPrIJ-0005yW-ES for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2008 00:03:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPrID-0005y5-Nc for emacs-devel@gnu.org; Mon, 04 Aug 2008 00:03:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPrID-0005xt-1o for emacs-devel@gnu.org; Mon, 04 Aug 2008 00:03:33 -0400 Original-Received: from [199.232.76.173] (port=53247 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPrIC-0005xq-Us for emacs-devel@gnu.org; Mon, 04 Aug 2008 00:03:32 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:62655) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KPrIC-0000ei-CK for emacs-devel@gnu.org; Mon, 04 Aug 2008 00:03:32 -0400 X-ICS-MailScanner-Watermark: 1218427351.16402@6OJL68F6HIPARfq7IFuzTA Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m7442ThQ023968; Sun, 3 Aug 2008 21:02:29 -0700 (PDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Mon, 04 Aug 2008 12:49:59 +0900") Original-Lines: 28 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102024 Archived-At: YAMAMOTO Mitsuharu writes: > >>>>> On Sun, 03 Aug 2008 19:26:24 -0700, Dan Nicolaescu said: > > >> It's quite a common way in the Emacs code to comment out with #if 0 > >> with leaving some explanation about why it is disabled. Especially > >> for the case that people might make the same mistake again in > >> future unconsciously if that part were completely removed. > > > So? Everyone is aware of that. But that was absolutely not the case > > in this particular instance. The comments and code did not make the > > intention clear for the casual reader. > > Would casual readers care about admin/CPP-DEFINES? Of course, that is why it exists. > > If you actually want to contribute something positive, please add > > the missing documentation and fix the code. > > It's not just a local problem. I'm concerned about possible removals > of other important comments in your past/future cleanups. It's really > inefficient if every developer has to check the excessive removal of > comments in (inherently optional) cleanups. As usual you are making a mountain out of a molehill and making a racket _again_ from nothing. Sorry, this is beyond silly. So again: QUIT WAISTING MY TIME!