all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v
Date: Tue, 29 Jul 2008 00:46:40 +0200	[thread overview]
Message-ID: <20080728224640.GB894@orion.lan> (raw)
In-Reply-To: <E1KNAva-0007QI-CF@cvs.savannah.gnu.org>

On Sun, Jul 27, 2008 at 06:25:06PM +0000, Dan Nicolaescu wrote:

> CVSROOT:	/cvsroot/emacs
> Module name:	emacs
> Changes by:	Dan Nicolaescu <dann>	08/07/27 18:24:49
> 
> Index: src/emacs.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/emacs.c,v
> retrieving revision 1.437
> retrieving revision 1.438
> diff -u -b -r1.437 -r1.438
> --- src/emacs.c	23 Jul 2008 23:37:17 -0000	1.437
> +++ src/emacs.c	27 Jul 2008 18:24:40 -0000	1.438
> @@ -837,7 +837,7 @@
>      run_time_remap (argv[0]);
>  #endif
>  
> -#if defined (MAC_OSX) || defined (NS_IMPL_COCOA)
> +#if defined (NS_IMPL_COCOA)
>    if (!initialized)
>      unexec_init_emacs_zone ();
>  #endif

This hunk is wrong and breaks malloc on os x when building without
toolkit. The reason to have two macros, MAC_OSX and HAVE_CARBON, was to
distinguish bare os x support from carbon gui AFAIU. I didn't check if
there are similar changes to revert as well.

Emanuele




       reply	other threads:[~2008-07-28 22:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1KNAva-0007QI-CF@cvs.savannah.gnu.org>
2008-07-28 22:46 ` Emanuele Giaquinta [this message]
2008-07-28 22:59   ` [Emacs-diffs] Changes to emacs/src/emacs.c,v Dan Nicolaescu
2008-07-28 23:18     ` Emanuele Giaquinta
2008-07-28 23:28       ` Dan Nicolaescu
2008-07-29  7:58         ` Emanuele Giaquinta
2008-07-29 13:13           ` Dan Nicolaescu
2008-07-29 13:40             ` Emanuele Giaquinta
2008-07-29 14:00               ` Dan Nicolaescu
2008-07-29  2:47     ` Stefan Monnier
2008-07-29  4:43       ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728224640.GB894@orion.lan \
    --to=emanuele.giaquinta@gmail.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.