Re: line-line-move-visual: was line motion problem

[Dan Nicolaescu <dann@ics.uci.edu>]

David Reitter <david.reitter@gmail.com> writes:

  > On 21 Jul 2008, at 00:49, Chong Yidong wrote:
  > Any objections to the patch below.

Some nits below:

  > *** whitespace.el	06 May 2008 03:57:59 -0400	1.80
  > --- whitespace.el	21 Jul 2008 11:04:45 -0400	
  > ***************
  > *** 2352,2357 ****
  > --- 2352,2406 ----
  >         (whitespace-mode -1)))
  >     nil)					; continue standard unloading
  > 
  > + \f
  > + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  > +
  > +
  > +
  > + ;; Show-newlines-mode
  > + (defface blank-newline
               ^^^^
Everything else in the file uses "whitespace", better not use a new prefix.

  > +  '((((class color) (background dark))
  > +     (:foreground "lightgrey" :bold nil))
  > +    (((class color) (background light))
  > +     ( :foreground "lightgrey" :bold nil))
  > +    (t (:bold nil :underline t)))
  > +  "Face used to visualize NEWLINE char mapping.
  > +
  > + See `blank-display-mappings'."
  > +  :group 'blank)
       ^^^^^^
This group does not exist.

Didn't look at the rest...