C++-mode, wrong indentation

C++-mode, wrong indentation

[Kevin Yu]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi,

====code====
if (x < 0 || y < 0 || x >= 9) {
                       // c++-mode will indent this line with
2*c-basic-offset when editing.
            } // and this line with c-basic-offset
====code====

If you copy the above code into a c++-mode buffer, the indentation is right.
But when you reenter the ">=" of first line, the indentation goes wrong
again.


Best regards
   Thanks.

[-- Attachment #2: Type: text/html, Size: 632 bytes --]

Re: C++-mode, wrong indentation

[Alan Mackenzie]

Hi, Kevin!

On Wed, Jul 02, 2008 at 12:59:36PM +0800, Kevin Yu wrote:
> Hi,

> ====code====
> if (x < 0 || y < 0 || x >= 9) {
>                        // c++-mode will indent this line with
> 2*c-basic-offset when editing.
>             } // and this line with c-basic-offset
> ====code====

> If you copy the above code into a c++-mode buffer, the indentation is
> right.  But when you reenter the ">=" of first line, the indentation
> goes wrong again.

Yes.  This is a bug.

If you're interested in what's happening, (you don't have to be ;-):

#########################################################################
The problem is to do with CC Mode's suboptimal handling of templates in
C++ Mode and Java Mode.

If you delete the ">=", then type just the ">" (as a first step towards
typing ">="), CC Mode spuriously recognises the "<..>" pair as template
brackets.  You can see this with show-paren-mode, or C-M-p.

When you then type the "=", it leaves the "<" as a bracket, but not the
">".  This messes up the paren matching, and causes mis-analysis of the
following lines of code.
#########################################################################

I can probably fix this quite easily.

Many thanks for a crisp, high quality bug report!

> Best regards
>    Thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: C++-mode, wrong indentation

[Alan Mackenzie]

Hello again, Kevin!

On Wed, Jul 02, 2008 at 09:57:31AM +0000, Alan Mackenzie wrote:
> Hi, Kevin!

> On Wed, Jul 02, 2008 at 12:59:36PM +0800, Kevin Yu wrote:
> > Hi,

> > ====code====
> > if (x < 0 || y < 0 || x >= 9) {
> >                        // c++-mode will indent this line with
> > 2*c-basic-offset when editing.
> >             } // and this line with c-basic-offset
> > ====code====

> > If you copy the above code into a c++-mode buffer, the indentation is
> > right.  But when you reenter the ">=" of first line, the indentation
> > goes wrong again.

> Yes.  This is a bug.

[ .... ]

> I can probably fix this quite easily.

Correction: I can probably fix this.  ;-(  It's a bit trickier than I
thought it would be.  I'm working on it.

-- 
Alan Mackenzie (Nuremberg, Germany).

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08

Re: C++-mode, wrong indentation

[Alan Mackenzie]

Hi, Keven,

On Wed, Jul 02, 2008 at 12:59:36PM +0800, Kevin Yu wrote:
> Hi,

> ====code====
> if (x < 0 || y < 0 || x >= 9) {
>                        // c++-mode will indent this line with
> 2*c-basic-offset when editing.
>             } // and this line with c-basic-offset
> ====code====

> If you copy the above code into a c++-mode buffer, the indentation is
> right.  But when you reenter the ">=" of first line, the indentation
> goes wrong again.

I've just committed a fix to this into the Emacs bzr repository.  Also
into the CC Mode cvs repository at SourceForge.  Don't tell me you forgot
about this?  ;-)

> Best regards
>    Thanks.

Sincerely,

-- 
Alan Mackenzie (Nuremberg, Germany).