bug#501: 23.0.60; Viewing SVG files: Error when pressing C-v, M-v

bug#501: 23.0.60; Viewing SVG files: Error when pressing C-v, M-v

[Markus Triska]

When I open the file

   http://www.logic.at/prolog/test.svg

with "emacs -Q test.svg", and then press C-c C-c to view the image, it
is displayed correctly. When I then press C-v or M-v to scroll, I get:

   Wrong type argument: listp, t

The debug output with M-x toggle-debug-on-error is:

   Debugger entered--Lisp error: (wrong-type-argument listp t)
     image-mode-winprops(nil)
     image-mode-window-put(vscroll 17 nil)
     image-set-window-vscroll(17)
     image-next-line(31)
     image-scroll-up(nil)
     call-interactively(image-scroll-up nil nil)


In GNU Emacs 23.0.60.1 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-06-29 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#501: Acknowledgement (23.0.60; Viewing SVG files: Error when pressing C-v, M-v)

[Markus Triska]

The following patch fixes this problem for me.

2008-07-18  Markus Triska  <markus.triska@gmx.at>

	* image-mode.el (image-toggle-display): Record scroll settings
	when switching to image.

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 00f2225..5ffbfe1 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -450,6 +450,7 @@ and showing the image as an image."
 	   (modified (buffer-modified-p)))
       (image-refresh image)
       (add-text-properties (point-min) (point-max) props)
+      (image-mode-setup-winprops)
       (set-buffer-modified-p modified)
       ;; Inhibit the cursor when the buffer contains only an image,
       ;; because cursors look very strange on top of images.

bug#501: marked as done (23.0.60; Viewing SVG files: Error when pressing C-v, M-v)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]


Your message dated Fri, 25 Jul 2008 01:45:00 -0400
with message-id <87y73q4iw3.fsf@stupidchicken.com>
and subject line Re: 23.0.60; Viewing SVG files: Error when pressing C-v, M-v
has caused the Emacs bug report #501,
regarding 23.0.60; Viewing SVG files: Error when pressing C-v, M-v
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
501: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=501
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3045 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Viewing SVG files: Error when pressing C-v, M-v
Date: Sun, 29 Jun 2008 14:37:51 +0200 (CEST)
Message-ID: <20080629123751.A9A8A92F185@mt-computer.local>


When I open the file

   http://www.logic.at/prolog/test.svg

with "emacs -Q test.svg", and then press C-c C-c to view the image, it
is displayed correctly. When I then press C-v or M-v to scroll, I get:

   Wrong type argument: listp, t

The debug output with M-x toggle-debug-on-error is:

   Debugger entered--Lisp error: (wrong-type-argument listp t)
     image-mode-winprops(nil)
     image-mode-window-put(vscroll 17 nil)
     image-set-window-vscroll(17)
     image-next-line(31)
     image-scroll-up(nil)
     call-interactively(image-scroll-up nil nil)


In GNU Emacs 23.0.60.1 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-06-29 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1312 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Markus Triska <markus.triska@gmx.at>
Cc: 501-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; Viewing SVG files: Error when pressing C-v, M-v
Date: Fri, 25 Jul 2008 01:45:00 -0400
Message-ID: <87y73q4iw3.fsf@stupidchicken.com>

> When I open the file
>
>    http://www.logic.at/prolog/test.svg
>
> with "emacs -Q test.svg", and then press C-c C-c to view the image, it
> is displayed correctly. When I then press C-v or M-v to scroll, I get:
>
>    Wrong type argument: listp, t

I've just checked in a fix.  Thanks.