all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
To: Jim Meyering <jim@meyering.net>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: emacs' turn: remove useless if-before-free tests
Date: Sun, 8 Jun 2008 12:53:25 +0200	[thread overview]
Message-ID: <20080608105325.GB42765@orion.lan> (raw)
In-Reply-To: <87abi4fjnp.fsf@rho.meyering.net>

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On Mon, Jun 02, 2008 at 08:14:18AM +0200, Jim Meyering wrote:

> Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > Sounds like a good cleanup.
> > Feel free to install it unless there's a strong objection.
> 
> Thanks.  I've committed those three change sets.

This patch introduced a problem on os x, free on os x is redirected to
unexmacosx.c:unexec_free, which does not support a NULL argument in an
undumped emacs. The attached patch changes the problematic free call to
xfree, as done a few lines below for another pointer.

Emanuele

[-- Attachment #2: free.diff --]
[-- Type: text/x-diff, Size: 314 bytes --]

diff --git a/src/lread.c b/src/lread.c
index e5e77bc..3e0bd1f 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -1269,7 +1269,7 @@ Return t if the file exists and loads successfully.  */)
 
   UNGCPRO;
 
-  free (saved_doc_string);
+  xfree (saved_doc_string);
   saved_doc_string = 0;
   saved_doc_string_size = 0;
 

  reply	other threads:[~2008-06-08 10:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-31 16:29 emacs' turn: remove useless if-before-free tests Jim Meyering
2008-06-01  1:25 ` Miles Bader
2008-06-01 11:10   ` Jim Meyering
2008-06-01 13:48     ` Miles Bader
2008-06-01 14:35       ` Jim Meyering
2008-06-01 14:51         ` David Kastrup
2008-06-01 15:57           ` Miles Bader
2008-06-01 14:03 ` Richard M Stallman
2008-06-01 14:22   ` Jim Meyering
2008-06-02 10:54     ` Richard M Stallman
2008-06-02 11:22       ` Jim Meyering
2008-06-01 21:41 ` Stefan Monnier
2008-06-02  0:56   ` YAMAMOTO Mitsuharu
2008-06-02  2:05     ` Miles Bader
2008-06-02  2:34       ` YAMAMOTO Mitsuharu
2008-06-02 16:30         ` Richard M Stallman
2008-06-02  2:26     ` Stefan Monnier
2008-06-02  6:14   ` Jim Meyering
2008-06-08 10:53     ` Emanuele Giaquinta [this message]
2008-06-08 12:31       ` Jim Meyering
2008-06-10 10:25         ` Jim Meyering
2008-06-12 22:54           ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080608105325.GB42765@orion.lan \
    --to=emanuele.giaquinta@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=jim@meyering.net \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.