From: Harald Hanche-Olsen <hanche@math.ntnu.no>
To: monnier@IRO.UMontreal.CA
Cc: emacs-devel@gnu.org
Subject: Re: (aset UNIBYTE-STRING MULTIBYTE-CHAR)
Date: Wed, 14 May 2008 14:50:43 +0200 (CEST) [thread overview]
Message-ID: <20080514.145043.228449419.hanche@math.ntnu.no> (raw)
In-Reply-To: <jwvabit849o.fsf-monnier+emacs@gnu.org>
+ Stefan Monnier <monnier@IRO.UMontreal.CA>:
> > + Harald Hanche-Olsen <hanche@math.ntnu.no>:
>
> >> This works as it should in the latest CVS:
> >>
> >> (setq foo (make-string 4 ?a))
> >> (aset foo 1 ?€) ; <= that's a euro sign
> >>
> >> But this fails:
> >>
> >> (setq foo (make-string 4 ?a))
> >> (aset foo 1 ?å)
> >> (aset foo 1 ?€) ; => Error: args out of range
>
> Show us the real code that bunmped into the problem and I'll tell you
> how to do it so as to avoid the risk of such problems.
You'd have to tell the author of mew (http://mew.org/), Kazu Yamamoto.
Actually, I have a one line patch to mew that fixes the problem, but
he seems unwilling to apply it.
Now don't get me wrong: I am not asking for a change in emacs to fix a
problem in mew. I am suggesting a change in emacs for the sake of
robustness: I think that if the problem of inserting multibyte
characters in unibyte strings is worth fixing at all, it is worth
fixing so it works in all cases. Otherwise, why bother? I do
understand the arguments against fixing it, but the current situation
where it will often work, but fail sometimes does not seem good to me.
But at least, it's documented, I see that now:
4.4 Modifying Strings
=====================
The most basic way to alter the contents of an existing string is with
`aset' (*note Array Functions::). `(aset STRING IDX CHAR)' stores CHAR
into STRING at index IDX. Each character occupies one or more bytes,
and if CHAR needs a different number of bytes from the character
already present at that index, `aset' signals an error.
That last bit actually seems to be outdated: An error is not ALWAYS
signaled in the indicated situation, only sometimes.
Anyway, the code you're asking for (in case you're really curious):
In mew-header.el
(defun mew-addrstr-parse-syntax-list (str sep addrp &optional depth allow-spc)
(when str
(let* ((i 0) (len (length str))
(par-cnt 0) (tmp-cnt 0) (sep-cnt 0)
(tmp (mew-make-string len))
c ret prevc)
(catch 'max
(while (< i len)
(setq c (aref str i)) ; <= problem occurs here
... deleted ...)))))
My one-line fix consists of changing the definition (elsewhere)
(defun mew-make-string (len)
(make-string len ?a))
into one that makes a multibyte string at the outset.
(I like mew (a lot), so I am willing to put up with its various
idiosynchrasies (and there are a some).)
- Harald
next prev parent reply other threads:[~2008-05-14 12:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 19:31 (aset UNIBYTE-STRING MULTIBYTE-CHAR) Harald Hanche-Olsen
2008-05-14 6:54 ` Harald Hanche-Olsen
2008-05-14 12:22 ` Stefan Monnier
2008-05-14 12:50 ` Harald Hanche-Olsen [this message]
2008-05-15 1:18 ` Stefan Monnier
2008-05-15 6:11 ` Harald Hanche-Olsen
-- strict thread matches above, loose matches on Subject: below --
2008-04-15 7:11 Kenichi Handa
2008-04-15 15:52 ` Stefan Monnier
2008-04-17 1:13 ` Kenichi Handa
2008-02-13 2:36 Kenichi Handa
2008-02-13 2:49 ` Stefan Monnier
2008-02-13 3:48 ` Kenichi Handa
2008-02-13 15:33 ` Stefan Monnier
2008-02-13 18:06 ` Stephen J. Turnbull
2008-02-13 19:33 ` Stefan Monnier
2008-02-13 22:49 ` Miles Bader
2008-02-14 1:11 ` Stephen J. Turnbull
2008-02-14 1:17 ` Miles Bader
2008-02-14 1:40 ` Stefan Monnier
2008-02-14 1:49 ` Miles Bader
2008-02-14 18:10 ` Richard Stallman
2008-02-14 22:40 ` David Kastrup
2008-02-15 1:08 ` Stephen J. Turnbull
2008-02-15 1:17 ` Miles Bader
2008-02-15 7:27 ` David Kastrup
2008-02-15 12:58 ` Richard Stallman
2008-02-14 23:37 ` Leo
2008-02-15 12:59 ` Richard Stallman
2008-02-14 4:20 ` Stephen J. Turnbull
2008-02-14 4:42 ` Richard Stallman
2008-02-15 1:39 ` Kenichi Handa
2008-02-15 4:27 ` Stefan Monnier
2008-02-15 8:42 ` Eli Zaretskii
2008-02-15 8:53 ` Miles Bader
2008-02-16 12:55 ` Eli Zaretskii
2008-02-16 5:53 ` Richard Stallman
2008-02-16 14:33 ` Stefan Monnier
2008-02-17 20:29 ` Richard Stallman
2008-02-18 1:15 ` Stefan Monnier
2008-02-18 4:00 ` Kenichi Handa
2008-02-18 17:31 ` Richard Stallman
2008-02-13 22:01 ` Richard Stallman
2008-02-13 23:13 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514.145043.228449419.hanche@math.ntnu.no \
--to=hanche@math.ntnu.no \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.