From: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: autoloads question
Date: Mon, 12 May 2008 16:59:08 +0200 [thread overview]
Message-ID: <20080512145908.GD8357@orion.lan> (raw)
In-Reply-To: <jwvy76foawe.fsf-monnier+emacs@gnu.org>
On Mon, May 12, 2008 at 10:28:01AM -0400, Stefan Monnier wrote:
> >>>>> "Emanuele" == Emanuele Giaquinta <emanuele.giaquinta@gmail.com> writes:
>
> > On Mon, May 12, 2008 at 12:42:09PM +0200, Juanma Barranquero wrote:
> >> On Mon, May 12, 2008 at 12:09 PM, Emanuele Giaquinta
> >> <emanuele.giaquinta@gmail.com> wrote:
> >>
> >> > -;;;;;; "widget.el" "window.el" "x-dnd.el") (18472 4851 825214))
> >> > +;;;;;; "widget.el" "window.el" "x-dnd.el") (18472 4853 658506))
> >> >
> >> > Is it expected?
> >>
> >> That is a timestamp.
>
> > Ah I see, thanks.
> > It is a bit boring because it causes an unneeded rebuild of emacs.
>
> I use the patch below to avoid the problem,
> @@ -632,7 +725,12 @@
> (current-buffer) nil nil no-autoloads this-time)
> (insert generate-autoload-section-trailer))
>
> - (save-buffer)
> + ;; Don't modify the file if its content has not been changed, so make
> + ;; dependencies don't trigger unnecessarily. This fails to update the
> + ;; time-stamp of the `no-autoloads' section, so it may cause redundant
> + ;; scans of files in future invocations. I.e. it's a trade-off.
> + (when changed (save-buffer))
> +
> ;; In case autoload entries were added to other files because of
> ;; file-local autoload-generated-file settings.
> (autoload-save-buffers))))
>
Wouldn't it be better to save the file mtime and restore it with
set-file-times if changed is nil?
Emanuele
next prev parent reply other threads:[~2008-05-12 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:09 autoloads question Emanuele Giaquinta
2008-05-12 10:42 ` Juanma Barranquero
2008-05-12 10:52 ` Emanuele Giaquinta
2008-05-12 14:28 ` Stefan Monnier
2008-05-12 14:59 ` Emanuele Giaquinta [this message]
2008-05-12 16:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512145908.GD8357@orion.lan \
--to=emanuele.giaquinta@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.