From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Carbon port and multi-tty Date: Wed, 07 May 2008 18:03:40 -0700 Message-ID: <200805080103.m4813eWH020955@sallyv1.ics.uci.edu> References: <87r6cf1if3.fsf@stupidchicken.com> <200805070428.m474SbH6002408@sallyv1.ics.uci.edu> <200805070555.m475tCRi004681@sallyv1.ics.uci.edu> <200805070715.m477FqOT010542@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210208716 6974 80.91.229.12 (8 May 2008 01:05:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 May 2008 01:05:16 +0000 (UTC) Cc: Chong Yidong , Stefan Monnier , emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 08 03:05:51 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtuZD-0001jF-Jf for ged-emacs-devel@m.gmane.org; Thu, 08 May 2008 03:05:15 +0200 Original-Received: from localhost ([127.0.0.1]:57588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtuYV-0008In-L0 for ged-emacs-devel@m.gmane.org; Wed, 07 May 2008 21:04:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtuYR-0008Ii-Kr for emacs-devel@gnu.org; Wed, 07 May 2008 21:04:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtuYR-0008IW-47 for emacs-devel@gnu.org; Wed, 07 May 2008 21:04:15 -0400 Original-Received: from [199.232.76.173] (port=55146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtuYQ-0008IT-UY for emacs-devel@gnu.org; Wed, 07 May 2008 21:04:14 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:63902) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JtuYQ-0001SD-9S for emacs-devel@gnu.org; Wed, 07 May 2008 21:04:14 -0400 X-ICS-MailScanner-Watermark: 1210813421.47021@AqxVrSW0/0OqLHUj0QEy9w Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m4813eWH020955; Wed, 7 May 2008 18:03:40 -0700 (PDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Thu, 08 May 2008 09:21:31 +0900") Original-Lines: 58 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96719 Archived-At: YAMAMOTO Mitsuharu writes: > >>>>> On Wed, 07 May 2008 00:15:52 -0700, Dan Nicolaescu said: > > > YAMAMOTO Mitsuharu writes: > >> >>>>> On Tue, 06 May 2008 22:55:12 -0700, Dan Nicolaescu > >> said: > >> > >> >> The bug introduced by this change is mentioned here: >> > >> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01069.html > >> > >> > OK, a 1 line change (in a ~1000 lines patch) that you seemed to > >> have > known about for a while. > >> > >> 1-line change can introduce a nasty bug as actually seen in this > >> case. And this could be easily avoided by not changing the part > >> that is unrelated to multi-tty. > > > And it would have been easily fixed, like all other bugs in emacs, > > had the platform not been declared unmaintained the moment the patch > > came out. Not saying that without the patch the code would not even > > compile. Not mentioning that you could have simply fixed it without > > causing all this racket. > > Again, I'm saying about mixing unrelated changes, not this particular > single-line bug. Please don't understate the problem. You keep repeating the same thing over and over. We heard you the first time, and nobody agreed. We have all realized by now that you are making a mountain out of a mole hill. This code has been in CVS for a year, you have made a choice to neither undo it, nor move a single finger to make it completely functional. The fact that you have known about a one line bug for 4 months and chose not to fix it, but instead create all this commotion did not win you any friends. You have already been told by the 2 head Emacs maintainers: "If you're disturbed by the remaining problems on Carbon, please try working on a fix instead of complaining." "If you can do better, show us. Otherwise, please stop complaining" PLEASE STOP WASTING OUR TIME. > And about this ChangeLog entry: > > 2008-05-07 Dan Nicolaescu > > * macfns.c (Fx_create_frame): Make a copy of frame parameters > because the original parameters are in pure storage now. > > The primary purpose of the copying is not for the parameters allocated > in the pure storage, but to prepare for frame parameter clearing in > x_get_arg. This is the same ChangeLog used by Martin Rudalics to fix a similar problem that was discovered by Juanma Barranquero that manifested itself by trying to write to pure storage.