23.0.60; Building from cvs on Hurd

23.0.60; Building from cvs on Hurd

[Evans Winner]

I am trying to compile Emacs from today/yesterday cvs on a
freshly installed Debian/GNU/Hurd/Mach (K16) system.  (That
platform is supported, isn't it?).  I have tried a couple of
different times with different ./configure options, but
always get the compile error in sysdep.c.  I have included
what looks like the relevant bit inline below.  I'm sorry
that I have absolutely no idea how to debug non-trivial C
code.  I hope this might be useful.  Please ask for any
other desired information.

=====================

The bit the error message seems to refer to (with a few
lines of context) is:

#ifndef DOS_NT
  struct emacs_tty s;

  EMACS_GET_TTY (out, &s);

#if defined (HAVE_TERMIO) || defined (HAVE_TERMIOS)
  s.main.c_oflag |= OPOST;	/* Enable output postprocessing */
  s.main.c_oflag &= ~ONLCR;	/* Disable map of NL to CR-NL on output */
#ifdef NLDLY
  s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY|FFDLY);
  				/* No output delays */

======================

[uname -a: GNU hurd 0.3 GNU-Mach 1.3.99/Hurd-0.3 i386-AT386
GNU]

======================

Output of make bootstrap:

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/home/thorne/src/emacs/src    -g -O2 -Wno-pointer-sign  sysdep.c
sysdep.c: In function 'wait_for_termination':
sysdep.c:491: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c:494: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c: In function 'child_setup_tty':
sysdep.c:605: error: 'FFDLY' undeclared (first use in this function)
sysdep.c:605: error: (Each undeclared identifier is reported only once
sysdep.c:605: error: for each function it appears in.)
sysdep.c: In function 'request_sigio':
sysdep.c:997: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:997: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c:999: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:999: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c: In function 'unrequest_sigio':
sysdep.c:1016: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:1018: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
make[2]: *** [sysdep.o] Error 1
make[2]: Leaving directory `/home/thorne/src/emacs/src'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/home/thorne/src/emacs'
make: *** [bootstrap] Error 2

Re: 23.0.60; Building from cvs on Hurd

[Glenn Morris]

Evans Winner wrote:

> sysdep.c: In function 'child_setup_tty':
> sysdep.c:605: error: 'FFDLY' undeclared (first use in this function)
> sysdep.c:605: error: (Each undeclared identifier is reported only once
> sysdep.c:605: error: for each function it appears in.)

Looks like you have NLDLY defined, but not FFDLY. Can you find the
include file that defines the former and see which *DLY it defines?

Try:

*** sysdep.c.~1.296.~   2008-04-09 00:07:23.000000000 -0700
--- sysdep.c            2008-05-09 16:57:06.000000000 -0700
***************
*** 601,607 ****
  #if defined (HAVE_TERMIO) || defined (HAVE_TERMIOS)
    s.main.c_oflag |= OPOST;   /* Enable output postprocessing */
    s.main.c_oflag &= ~ONLCR;  /* Disable map of NL to CR-NL on output
    */
! #ifdef NLDLY
    s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY|FFDLY);
                            /* No output delays */
  #endif
--- 601,607 ----
  #if defined (HAVE_TERMIO) || defined (HAVE_TERMIOS)
    s.main.c_oflag |= OPOST;   /* Enable output postprocessing */
    s.main.c_oflag &= ~ONLCR;  /* Disable map of NL to CR-NL on output
    */
! #if defined NLDLY && defined FFDLY
    s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY|FFDLY);
                            /* No output delays */
  #endif

Re: 23.0.60; Building from cvs on Hurd

[Evans Winner]

Glenn Morris <rgm@gnu.org> writes:

    Looks like you have NLDLY defined, but not FFDLY. Can
    you find the include file that defines the former and
    see which *DLY it defines?

I am not totally sure what that means, but:

,----[ grep -r NLDLY /hurd/usr/include/* ]
| /hurd/usr/include/bits/ioctls.h:#define		NLDLY		0x00000300	/* \n delay */
| /hurd/usr/include/bits/ioctls.h:#define		NLDELAY		NLDLY		/* traditional BSD name */
`----

 
    Try:
    [...] 

    ! #if defined NLDLY && defined FFDLY

    [...]

Yay!  That caused it to compile all the way and install.
Thank you.

It did not pass the smoke test, though, but I am pretty sure
it's unrelated to Emacs.  (Starting Emacs at the prompt
results in an error (I didn't write it down, but it was
something like) ``emacs: cannot configure tty device
/dev/tty''.  I will look into it.)  Anyway, thanks again.

Re: 23.0.60; Building from cvs on Hurd

[Glenn Morris]

Evans Winner wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>     Looks like you have NLDLY defined, but not FFDLY. Can
>     you find the include file that defines the former and
>     see which *DLY it defines?
>
> I am not totally sure what that means, but:
>
> ,----[ grep -r NLDLY /hurd/usr/include/* ]
> | /hurd/usr/include/bits/ioctls.h:#define		NLDLY		0x00000300	/* \n delay */

Sorry, I meant:

Find the file that defines NLDLY (/hurd/usr/include/bits/ioctls.h),
and see which of the following symbols it defines:

NLDLY, CRDLY, TABDLY, BSDLY, VTDLY, FFDLY

It seems to be all but the last, in which case a better patch is
probably:

*** sysdep.c    9 Apr 2008 06:46:14 -0000 1.296
--- sysdep.c    10 May 2008 19:58:13 -0000
***************
*** 602,609 ****
--- 602,616 ----
    s.main.c_oflag |= OPOST;    /* Enable output postprocessing */
    s.main.c_oflag &= ~ONLCR;   /* Disable map of NL to CR-NL on output */
  #ifdef NLDLY
+   /* http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg00406.html
+      Some versions of GNU Hurd do not have FFDLY?  */
+ #ifdef FFDLY
    s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY|FFDLY);
                            /* No output delays */
+ #else
+   s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY);
+                           /* No output delays */
+ #endif
  #endif
    s.main.c_lflag &= ~ECHO;    /* Disable echo */
    s.main.c_lflag |= ISIG;     /* Enable signals */

bug#194: marked as done (23.0.60; Building from cvs on Hurd)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]


Your message dated Thu, 29 May 2008 19:11:17 -0400
with message-id <18495.14357.586619.208707@fencepost.gnu.org>
and subject line Re: 23.0.60; Building from cvs on Hurd 
has caused the Emacs bug report #194,
regarding 23.0.60; Building from cvs on Hurd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
194: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=194
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6705 bytes --]

From: Evans Winner <thorne@timbral.net>
To: emacs-pretest-bug@gnu.org
Cc: 
Subject: 23.0.60; Building from cvs on Hurd
Date: Tue,  6 May 2008 22:59:01 -0600 (MDT)
Message-ID: <20080507045901.039E41B505@mail.timbral.net>

I am trying to compile Emacs from today/yesterday cvs on a
freshly installed Debian/GNU/Hurd/Mach (K16) system.  (That
platform is supported, isn't it?).  I have tried a couple of
different times with different ./configure options, but
always get the compile error in sysdep.c.  I have included
what looks like the relevant bit inline below.  I'm sorry
that I have absolutely no idea how to debug non-trivial C
code.  I hope this might be useful.  Please ask for any
other desired information.

=====================

The bit the error message seems to refer to (with a few
lines of context) is:

#ifndef DOS_NT
  struct emacs_tty s;

  EMACS_GET_TTY (out, &s);

#if defined (HAVE_TERMIO) || defined (HAVE_TERMIOS)
  s.main.c_oflag |= OPOST;	/* Enable output postprocessing */
  s.main.c_oflag &= ~ONLCR;	/* Disable map of NL to CR-NL on output */
#ifdef NLDLY
  s.main.c_oflag &= ~(NLDLY|CRDLY|TABDLY|BSDLY|VTDLY|FFDLY);
  				/* No output delays */

======================

[uname -a: GNU hurd 0.3 GNU-Mach 1.3.99/Hurd-0.3 i386-AT386
GNU]

======================

Output of make bootstrap:

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/home/thorne/src/emacs/src    -g -O2 -Wno-pointer-sign  sysdep.c
sysdep.c: In function 'wait_for_termination':
sysdep.c:491: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c:494: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c: In function 'child_setup_tty':
sysdep.c:605: error: 'FFDLY' undeclared (first use in this function)
sysdep.c:605: error: (Each undeclared identifier is reported only once
sysdep.c:605: error: for each function it appears in.)
sysdep.c: In function 'request_sigio':
sysdep.c:997: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:997: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c:999: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:999: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)
sysdep.c: In function 'unrequest_sigio':
sysdep.c:1016: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
sysdep.c:1018: warning: 'sigblock' is deprecated (declared at /usr/include/signal.h:181)
make[2]: *** [sysdep.o] Error 1
make[2]: Leaving directory `/home/thorne/src/emacs/src'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/home/thorne/src/emacs'
make: *** [bootstrap] Error 2





[-- Attachment #3: Type: message/rfc822, Size: 1246 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 194-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; Building from cvs on Hurd
Date: Thu, 29 May 2008 19:11:17 -0400
Message-ID: <18495.14357.586619.208707@fencepost.gnu.org>


This has been fixed.