From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Redesigh of the VC front end Date: Tue, 06 May 2008 04:38:08 -0700 Message-ID: <200805061138.m46Bc8Yw010248@sallyv1.ics.uci.edu> References: <20080506003943.80ED89F054C@snark.thyrsus.com> <200805060114.m461EZ05007471@sallyv1.ics.uci.edu> <20080506082826.GD23773@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210074026 28022 80.91.229.12 (6 May 2008 11:40:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 11:40:26 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 13:41:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtLXW-0008BS-58 for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 13:40:58 +0200 Original-Received: from localhost ([127.0.0.1]:54343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtLWo-0005wl-AQ for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 07:40:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtLWj-0005wU-KT for emacs-devel@gnu.org; Tue, 06 May 2008 07:40:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtLWi-0005wI-WA for emacs-devel@gnu.org; Tue, 06 May 2008 07:40:09 -0400 Original-Received: from [199.232.76.173] (port=43895 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtLWi-0005wF-RZ for emacs-devel@gnu.org; Tue, 06 May 2008 07:40:08 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JtLWi-0006DY-9l for emacs-devel@gnu.org; Tue, 06 May 2008 07:40:08 -0400 X-ICS-MailScanner-Watermark: 1210678689.46783@uXrOxzFzJPfaQmMutujo8Q Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m46Bc8Yw010248; Tue, 6 May 2008 04:38:09 -0700 (PDT) In-Reply-To: <20080506082826.GD23773@thyrsus.com> (Eric S. Raymond's message of "Tue, 6 May 2008 04:28:26 -0400") Original-Lines: 32 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96584 Archived-At: "Eric S. Raymond" writes: > Dan Nicolaescu : > > "Eric S. Raymond" writes: > > > > > 2. Otherwise, if you are in a vc dired buffer, and > > > include-files-not-directories is non-nil, and no fileset is selected, > > > select all files at and below directory level. > > > > This is a wart that is used by vc-next-action for the following: if in a > > vc-dir buffer, you have a directory selected and do C-x v v what action > > should be performed? > > If you have files selected, the decision is made based on the files state. > > For directories, then with this flag, return the list of files is > > returned and the decision based on the file state. The VC action is > > still performed on the directory... > > Better ideas on how to handle this case are quite welcome. > > Hm. I think I see what you're driving at now. > > Here's what I think is right. We generalize vc-backend so it can take a > directory argument, The default semantics is just: look for a backend by > control subdirectory in the user's preference order. But if we select a > backend on the directory using C-u C-x v v, it should remember that. Sorry, this is not the issue described above. The code is question is not related to the backend, but to the vc _state_. Incidentally, the code in vc-next-action that verifies the fileset: ;; Verify that the fileset is homogeneous [snip] might fit better in vc-deduce-fileset (or whatever is called now).