From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: vc-directory breakage Date: Mon, 5 May 2008 20:48:49 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20080506004849.GA14523@thyrsus.com> References: <20080505152149.E5BB99F054B@snark.thyrsus.com> <857ie8ahr3.fsf@lola.goethe.zz> <20080506000456.GA14206@thyrsus.com> <200805060036.m460aVto021222@sallyv1.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210034907 18790 80.91.229.12 (6 May 2008 00:48:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 00:48:27 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 02:49:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtBMc-0004Lh-73 for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 02:49:02 +0200 Original-Received: from localhost ([127.0.0.1]:33362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBLu-0007WK-E7 for ged-emacs-devel@m.gmane.org; Mon, 05 May 2008 20:48:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtBLq-0007Tn-Bm for emacs-devel@gnu.org; Mon, 05 May 2008 20:48:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtBLp-0007SQ-1t for emacs-devel@gnu.org; Mon, 05 May 2008 20:48:13 -0400 Original-Received: from [199.232.76.173] (port=38693 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBLo-0007SH-ST for emacs-devel@gnu.org; Mon, 05 May 2008 20:48:12 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark.thyrsus.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtBLl-0008FB-UJ; Mon, 05 May 2008 20:48:10 -0400 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id 438AA9F054C; Mon, 5 May 2008 20:48:49 -0400 (EDT) Content-Disposition: inline In-Reply-To: <200805060036.m460aVto021222@sallyv1.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96555 Archived-At: Dan Nicolaescu : > "Eric S. Raymond" writes: > > > To my knowledge, VC is not in a broken state now. Stefan fixed one of > > the blocker bugs yesterday, probably while I was flat on my back and > > hooked up to a heart monitor, and I got the other one this morning. > > There still are some issues. This: > > (defun vc-generic-status-printer (fileentry) > (let* ((file (vc-dir-fileinfo->name fileentry)) > (backend (vc-responsible-backend file))) > (vc-call-backend backend 'status-printer fileentry))) > > is not quite right. > (vc-dir-fileinfo->name fileentry) is not an absolute file name, doing > vc-responsible-backend on that is not going to work. Ah. There's some Lisp function I need to wrap that arg in to make it a full pathname, then; I've forgotten which it is, though. If you remember before I do, feel free to fix it. > Also please put the backend in a buffer-local variable in the vc-dir > buffer, that way all the vc-responsible-backend calls in vc-generic-* can be > eliminated. > With that change this code will work. > It does not work right now for at least hg, git and svn. The recommended change may be a good idea, but I'm not sure. Those backend checks are now being done at file granularity because some people were vocal about support for mixing multiple VCSes in a directory. If we depended on a per-directory buffer-local variable, that would get more difficult. What is the actual failure you are seeing? -- Eric S. Raymond