a bug rendering ido unusable

a bug rendering ido unusable

[Paul Pogonyshev]

Hi,

I have recompiled Emacs from CVS today and found that ido no longer
differentiates between files and directories.  E.g. when I type
'~/ema RET' it opens directory '~/emacs' in dired mode, instead of
navigating into it inside the minibuffer.  It must be a bug since
I don't see how that is anywhere near useful.

OTOH, there doesn't seem to be any recent modifications of ido, so
this might be a problem in some other place, e.g. in a function
that does is-this-a-directory check.

This is on GNU/Linux, could matter.  'emacs -q' shows the same
behavior after 'M-x ido-mode'.

Paul

Re: a bug rendering ido unusable

[Kim F. Storm]

Paul Pogonyshev <pogonyshev@gmx.net> writes:

> Hi,
>
> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories.  E.g. when I type
> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> navigating into it inside the minibuffer.  It must be a bug since
> I don't see how that is anywhere near useful.
>
> OTOH, there doesn't seem to be any recent modifications of ido, so
> this might be a problem in some other place, e.g. in a function
> that does is-this-a-directory check.
>
> This is on GNU/Linux, could matter.  'emacs -q' shows the same
> behavior after 'M-x ido-mode'.

There has been a lot of changes to the basic completion stuff - maybe
some of those changes broke ido.

I don't have time to look into it at this time - so if someone else
could take a look I'd appreciate it.

Stefan, do you know what might have happened ??

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: a bug rendering ido unusable

[Stefan Monnier]

>> Hi,
>> 
>> I have recompiled Emacs from CVS today and found that ido no longer
>> differentiates between files and directories.  E.g. when I type
>> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
>> navigating into it inside the minibuffer.  It must be a bug since
>> I don't see how that is anywhere near useful.
>> 
>> OTOH, there doesn't seem to be any recent modifications of ido, so
>> this might be a problem in some other place, e.g. in a function
>> that does is-this-a-directory check.
>> 
>> This is on GNU/Linux, could matter.  'emacs -q' shows the same
>> behavior after 'M-x ido-mode'.

> There has been a lot of changes to the basic completion stuff - maybe
> some of those changes broke ido.

Yes, that's the most likely explanation.

> I don't have time to look into it at this time - so if someone else
> could take a look I'd appreciate it.

> Stefan, do you know what might have happened ??

The handling of completion predicate together with
read-file-name-internal has changed and I think it's the most
likely culprit.  I haven't had time to look into it yet, tho,


        Stefan

Re: a bug rendering ido unusable

[Stefan Monnier]

> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories.  E.g. when I type
> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> navigating into it inside the minibuffer.  It must be a bug since
> I don't see how that is anywhere near useful.

It turns out the problem is in file-name-all-completions: for some
reason, it fails to add the expected trailing / on directories.


        Stefan

RE: a bug rendering ido unusable

[Drew Adams]

> > I have recompiled Emacs from CVS today and found that ido no longer
> > differentiates between files and directories.  E.g. when I type
> > '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> > navigating into it inside the minibuffer.  It must be a bug since
> > I don't see how that is anywhere near useful.
> 
> It turns out the problem is in file-name-all-completions: for some
> reason, it fails to add the expected trailing / on directories.

Thanks for that info. I got a similar bug report for Icicles.

Re: a bug rendering ido unusable

[Stefan Monnier]

> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories.  E.g. when I type

It should be fixed now,


        Stefan

Re: a bug rendering ido unusable

[Paul Pogonyshev]

Stefan Monnier wrote:
> > I have recompiled Emacs from CVS today and found that ido no longer
> > differentiates between files and directories.  E.g. when I type
> 
> It should be fixed now,

Yes, it is.  Thank you.

Paul

Re: a bug rendering ido unusable

[Len Trigg]

Paul Pogonyshev wrote:
> Stefan Monnier wrote:
> > > I have recompiled Emacs from CVS today and found that ido no longer
> > > differentiates between files and directories.  E.g. when I type
> > 
> > It should be fixed now,
> 
> Yes, it is.  Thank you.

Hmmm, I did a clean build from CVS today, and it still happens for me
on at least one directory.  From ~/reeltwo_sandboxes/vetech/ all
completions show no trailing slash on subdirectories. I have no idea
why this directory behaves differently to others.


Cheers,
Len.

Re: a bug rendering ido unusable

[Len Trigg]

Paul Pogonyshev wrote:
> Stefan Monnier wrote:
> > > I have recompiled Emacs from CVS today and found that ido no longer
> > > differentiates between files and directories.  E.g. when I type
> > 
> > It should be fixed now,
> 
> Yes, it is.  Thank you.

Hmmm, I did a clean build from CVS today, and it still happens for me
on at least one directory.  From ~/reeltwo_sandboxes/vetech/ all
completions show no trailing slash on subdirectories. I have no idea
why this directory behaves differently to others.


Cheers,
Len.