all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tatsuya Kinoshita <tats@vega.ocn.ne.jp>
To: emacs-devel@gnu.org
Cc: nori1@dolphin.c.u-tokyo.ac.jp, czkmt@remus.dti.ne.jp
Subject: tmm.el: non-ASCII characters with locale-coding-system
Date: Wed, 16 Apr 2008 22:09:02 +0900 (JST)	[thread overview]
Message-ID: <20080416.220902.173219381.tats%nobody@tats.iris.ne.jp> (raw)

Hi Emacs developers,

Could you please consider applying the following patch to handle
non-ASCII characters with locale-coding-system for tmm.el?

----
--- tmm.el.orig	2008-02-08 22:47:00.000000000 +0900
+++ tmm.el	2008-03-14 08:08:04.000000000 +0900
@@ -171,7 +171,7 @@
     ;; The order of elements in tmm-km-list is the order of the menu bar.
     (mapc (lambda (elt)
 	    (if (stringp elt)
-		(setq gl-str elt)
+		(setq gl-str (decode-coding-string elt locale-coding-system))
 	      (and (listp elt) (tmm-get-keymap elt not-menu))))
 	    menu)
     ;; Choose an element of tmm-km-list; put it in choice.
@@ -282,6 +282,7 @@
 
 (defsubst tmm-add-one-shortcut (elt)
 ;; uses the free vars tmm-next-shortcut-digit and tmm-short-cuts
+  (setcar elt (decode-coding-string (car elt) locale-coding-system))
   (cond
    ((eq (cddr elt) 'ignore)
     (cons (concat " " (make-string (length tmm-mid-prompt) ?\-)
----

The patch is created by Tetsuo Tsukamoto (czkmt at remus.dti.ne.jp)
at http://mail.ring.gr.jp/skk/200803/msg00009.html to prevent a
problem of displaying Japanese characters with tmm.el reported
by Noritada Kobayashi at Debian BTS http://bugs.debian.org/470646.

To reproduce the problem,

* Install Daredevil SKK 13.1 (http://openlab.jp/skk/) and Emacs
  23.0.60 or 22.2.

* Run Emacs with `LC_ALL=ja_JP.UTF-8 emacs -q'.

* Type `M-x skk-mode RET', `M-`' and `s' to select the menu `s==>SKK',
  and then garbled characters (\351\240\230...) are displayed.

The patch works nicely on my system for Debian's ddskk 13.1-1,
emacs22 22.1+1-3 and Romain's emacs-snapshot 1:20080406-2.

Thanks,
-- 
Tatsuya Kinoshita




             reply	other threads:[~2008-04-16 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16 13:09 Tatsuya Kinoshita [this message]
2008-04-16 15:38 ` tmm.el: non-ASCII characters with locale-coding-system Stefan Monnier
2008-04-16 16:15   ` Tatsuya Kinoshita
2008-04-17 14:21     ` Tatsuya Kinoshita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080416.220902.173219381.tats%nobody@tats.iris.ne.jp \
    --to=tats@vega.ocn.ne.jp \
    --cc=czkmt@remus.dti.ne.jp \
    --cc=emacs-devel@gnu.org \
    --cc=nori1@dolphin.c.u-tokyo.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.