From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: byte-compile-maybe-guarded Date: Sat, 01 Mar 2008 17:00:43 -0800 Message-ID: <200803020100.m2210hmL011065@sallyv1.ics.uci.edu> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204419742 682 80.91.229.12 (2 Mar 2008 01:02:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Mar 2008 01:02:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 02 02:02:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JVcbF-0001jm-70 for ged-emacs-devel@m.gmane.org; Sun, 02 Mar 2008 02:02:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVcai-0003xR-Jw for ged-emacs-devel@m.gmane.org; Sat, 01 Mar 2008 20:02:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVcae-0003vK-Kn for emacs-devel@gnu.org; Sat, 01 Mar 2008 20:02:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVcab-0003u4-LT for emacs-devel@gnu.org; Sat, 01 Mar 2008 20:02:08 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVcaa-0003tr-TP for emacs-devel@gnu.org; Sat, 01 Mar 2008 20:02:04 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JVcaU-0001dV-MP; Sat, 01 Mar 2008 20:01:59 -0500 X-ICS-MailScanner-Watermark: 1205024444.81101@PFyTFxyORSg+0qn7hnp73g Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m2210hmL011065; Sat, 1 Mar 2008 17:00:44 -0800 (PST) Original-Lines: 29 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91023 Archived-At: Glenn Morris writes: > FYI I've restored the code in byte-compile-maybe-guarded that you > commented out 2007-11-10. Without this code, a false warning is > produced in the following case: Although restoring that code fixes the warning that you showed, is it the right thing to do? > foo.el: > (defsubst foo () > (if (featurep 'xemacs) (setq foo t))) ; foo is a free variable > (provide 'foo) > > bar.el: > (require 'foo) > (foo) > > > emacs -Q -batch --eval "(add-to-list 'load-path default-directory)" \ > -f batch-byte-compile bar.el If the defsubst in foo.el to is: (defsubst foo () (if (and t (featurep 'xemacs)) (setq foo t))) ; foo is a free variable the warning is still produced even after your change...