Re: byte-compile-maybe-guarded

[Dan Nicolaescu <dann@ics.uci.edu>]

Glenn Morris <rgm@gnu.org> writes:

  > FYI I've restored the code in byte-compile-maybe-guarded that you
  > commented out 2007-11-10. Without this code, a false warning is
  > produced in the following case:

Although restoring that code fixes the warning that you showed, is it
the right thing to do?

  > foo.el:
  > (defsubst foo ()
  >   (if (featurep 'xemacs) (setq foo t)))   ; foo is a free variable
  > (provide 'foo)
  > 
  > bar.el:
  > (require 'foo)
  > (foo)
  > 
  > 
  > emacs -Q -batch --eval "(add-to-list 'load-path default-directory)" \
  >    -f batch-byte-compile bar.el

If the defsubst in foo.el to is:

(defsubst foo ()
  (if (and t (featurep 'xemacs)) (setq foo t)))   ; foo is a free variable

the warning is still produced even after your change...